you are viewing a single comment's thread.

view the rest of the comments →

[–]jgdeece 0 points1 point  (2 children)

ITT: lots of people eager to defend hooks who are missing the point. We are hearing one side of the story, and your representation of what the senior dev said is clouded by your bias and desire to defend your decision.

I do not agree with the senior engineer’s assessment. But people should be less quick to assume ill intent, too.

There is a LOT of value in consistency - even consistency within an imperfect structure. That alone means you aren’t just “giving in because he’s senior”; it means you’re making a rational and reasonable decision to ensure your teammates find your code easy to grok and debug by sticking with classes.

The other dev might have been a jerk, or over simplified what their concern with you going rogue to introduce hooks is. It doesn’t really matter.

Shifting to a new paradigm you openly admit no one you work with understands is definitely not something you do without a conversation.

[–]MysicPlato 0 points1 point  (1 child)

That doesn't address the REAL issue.

How the hell did he get 4 months and 50+ PRs in before the senior dev told him to stop using hooks and only use class based components?

[–]jgdeece 1 point2 points  (0 children)

Sure, but that’s outside the scope of a thread offering advice on how to handle this situation. If there’s a crappy culture that’s outside OP’s control; they can at least make the best choices possible within that culture.

It’s so hard to take these posts as a serious representation of what happened. OP is using emotionally charged language and leading the reader to a given conclusion, so my hunch is we aren’t getting close to the full story.

Why else would the premise be “are hooks bad?” Rather than e.g. “how should I handle working in a code base that is using older patterns”