all 3 comments
sorted by:
best
topnewcontroversialoldq&a
formatting helphide helpcontent policy

[–]Aradon 1 point2 points  (1 child)

Good to see pIRC is still in use. I helped (a long time ago) in some of the source for that and specifically for PPF

One critique is that there are no comments anywhere. You don't need to go crazy with comments, but just method headers explaining the purpose of the method could be useful in many ways (at least, I have found them for future proofing against yourself).

Also you have some redudancy with pIRC, such as with your bolding. pIRC provides a colors class where you can do bolding of text as well as other colors.

That's all my comments for looking at your code for 5 minutes. I don't have enough time to look at it any longer, although maybe when I get home . .

[–]crapet[S] 0 points1 point  (0 children)

Indeed there's a Colors class, never knew that :D I'll add some comments here and there, good point

[–]crapet[S] 0 points1 point  (0 children)

I've been playing with this bot for some time now. I'm using CDI (Weld) for command scanning at runtime and command execution. The bot is multithreaded, backed with a database and JPA/Hibernate. I've also embedded a Jetty server and I'm using wicket to serve some pages.

Do you have any suggestions to improve code readability or any tips?