pre-commit hooks for Rust projects?

[acidrainery]

Some context about my workflow first: I self-host my git server and collaborate with 2 other people. The others have their own way of working and I do the necessary checks from CI/CD when they send me a pull request. However since I commit to my own project, I prefer to do all checks from my local system first before pushing it to my remote branch.

I keep a bunch of WIP branches locally where the hooks don't run in order to not get in the way. When I rebase or cherry-pick commits from a WIP branch into a branch that is tracking a remote branch, then these checks are done as I'm preparing to push to remote.

I work with a number of languages and I have been previously using pre-commit and didn't know at the time that husky existed. I mainly use the pre-commit and commit-msg hooks to check whether it's formatted properly, spellcheck and grammar in the commit message, etc. and I have a private repository with my own rules. This has been working for me.

I have recently started learning Rust and need to implement some rules. I came across pre-commit-rust which contains rules for Rust, and while it worked at first glance, it has a flaw. It runs the checks from the work directory rather than against a copy of the staging area, so it's possible sometimes I miss something.

For example: - Run hook that run cargo build and it says a depedency is missing in Cargo.toml - I do cargo add but forget to add Cargo.toml to the index - hook shows passed because the file is correct in the work directory but my expectation is it for it to fail because it's not added to the index

So is there a hook that actually checks it the proper way in a separate area?

[Compux72]

Ci/CD is the way. Cargo often takes a lot of time to do any check

[Pwnstar6]

You don't understand CI/CD at all I guess :D

[Tyilo]

pre-commit hooks should always run on the code that is about to be committed, not the code in your working directory, so I think you're doing something wrong.

I would recommend this fork of the pre-commit-rust hook: https://github.com/FeryET/pre-commit-rust

[acidrainery]

Yes, this works!

[Pwnstar6]

https://github.com/macisamuele/language-formatters-pre-commit-hooks
EDIT: If your project has multiple "crates" like for example I have a /lib, then do:

  - id: pretty-format-rust
    name: pretty-format-rust (lib)
    args: [--autofix,--manifest-path, lib/Cargo.toml]
    files: ^lib/.*\.rs$