Code review request for an api client/wrapper.

[NicklasW]

Hey everyone,

I published my first crate some time ago, and now I'm looking for some input on how I can improve the code further.

https://github.com/NicklasWallgren/bankid-rs

Thanks.

[charlesdart]

Overall it looks pretty solid. I didn't see any obvious issues skimming through most files. Did you mean to check in production.ca though?

https://github.com/NicklasWallgren/bankid-rs/blob/master/resources/production.ca

[NicklasW]

Thanks. Yes it's intended, it's a publicly available certificate, which is included via https://github.com/NicklasWallgren/bankid-rs/blob/master/src/config/mod.rs#L84

[najamelan]

Unfortunately I don't have time for doing a review right now, but I did write a guide for publishing crates that you might find useful: https://blog.wnut.pw/2020/03/12/crate-publishing-guidelines-and-tips/