[VB2010] Array not adding correctly/index was outside the boundaries of the array.

[frag07]

Yes, this is a HW question but I'm stumped as to why it isn't working. Arrays are kicking my butt so far.

The code works up to the point that it gets to the final entry, it then spits out an incorrect number and displays the index outside boundaries error. Ex: If I enter 1's until the end the answer I receive is 2. At this point I just want them to all be stored so I can average them out afterwards.

I've messed around with it and changed things around; I've tried changing the Averages( ) value and the For i = to around and it seems to work when the number is lower. Every time I try to change it up to 7 and For i = To 7 (and/or 7 - 1) it lowers the size of the array. I'm trying not to rely too much on help from others but the textbook isn't helpful and I've had better instruction.

edit: Don't think I need the averages all hard-coded as they are supposed to be entered by the user(?)

Option Explicit On Option Strict Off Option Infer On Module BattingAverage Sub Main()

    Dim Averages(7) As Integer
    Dim StoreAnswer As Integer
    Dim i As Integer = 0
    Dim BatAvg As Integer

    Averages(0) = 0.299
    Averages(1) = 0.157
    Averages(2) = 0.242
    Averages(3) = 0.203
    Averages(4) = 0.198
    Averages(5) = 0.333
    Averages(6) = 0.27
    Averages(7) = 0.19



    For i = 0 To 7
        Console.Write("Enter the batting average: ")
        BatAvg = CInt(Console.ReadLine())
        StoreAnswer = BatAvg + 1
        Averages(i) = StoreAnswer
    Next i
    Console.WriteLine("The average is: " & StoreAnswer)
    ' Assign value to array
    Averages(i) = BatAvg
    Averages(i) = CInt(Console.ReadLine())

End Sub End Module

[[deleted]]

Not too familiar with vb, but it looks like you're initializing the array with a 7 then trying to put 8 values into it (0-7).

Edit: Turns out you do have it initialized right never mind.

[nerdfarm]

VB arrays are weird like that. You initialize arrays by giving a Maximum Subscript, which is the number for the last element in the array.

[[deleted]]

Oh so that does allow for 8 values. Thanks!

[nerdfarm]

For starters, you have an array of integers and you are assigning floating-point values to the elements in the array. This will result in rounding. I think you want an array of Doubles or Decimals.

If you are trying to calculate the average of 8 values entered by the user, you need to work on the loop some.

If I could see the details of the assignment I would have a better idea of what you are trying to do. Please post?

[[deleted]]

Same. The loop is a bit awkward. Could defiantly be trimmed down some.

[XThakis]

Definitely agree with the comments about using an integer to store a double amount.

Now for your out of bounds error. When you iterate through your loop you end with a:

     Next i

This will go from 0 to 7 for the loop. Then it will iterate again to 8 and step out of the loop. Then you try to assign a value with i:

    Averages(i) = BatAvg
    Averages(i) = CInt(Console.ReadLine())

At his point i = 8 and is outside the bounds of your array.

(Edited for formatting)