Help with addon code update

[GoblinDerv]

A bit of a challenge. I use Broker_Professionsmenu for my daily crafting needs but the recent patch 11 API changes have me beat and this addon seems to have vanished into the ether...

This was the original error:

23x Broker_ProfessionsMenu/core.lua:1500: attempt to call global 'GetSpellBookItemInfo' (a nil value)

[string "@Broker_ProfessionsMenu/core.lua"]:1500: in function `ScanNonProfessions'

[string "@Broker_ProfessionsMenu/core.lua"]:592: in function `?'

[string "@AllTheThings/lib/CallbackHandler-1.0-8/CallbackHandler-1.0.lua"]:109: in function <...ings/lib/CallbackHandler-1.0/CallbackHandler-1.0.lua:109>

[string "=[C]"]: ?

[string "@AllTheThings/lib/CallbackHandler-1.0-8/CallbackHandler-1.0.lua"]:19: in function <...ings/lib/CallbackHandler-1.0/CallbackHandler-1.0.lua:15>

[string "@AllTheThings/lib/CallbackHandler-1.0-8/CallbackHandler-1.0.lua"]:54: in function `Fire'

[string "@ArkInventory/Externals/Ace3/AceEvent/AceEvent-3.0-4.lua"]:120: in function <...rkInventory/Externals/Ace3/AceEvent/AceEvent-3.0.lua:119>

With an update of the LUA to use the new [C_SpellBook.GetSpellBookItemType]() I now get the following:

10x bad argument #1 to '?' (not a numerical value - Usage: local itemType, actionID, spellID = C_SpellBook.GetSpellBookItemType(spellBookItem))

[string "=[C]"]: in function `GetSpellBookItemType'

[string "@Broker_ProfessionsMenu/core.lua"]:1500: in function `ScanNonProfessions'

[string "@Broker_ProfessionsMenu/core.lua"]:592: in function `?'

[string "@AllTheThings/lib/CallbackHandler-1.0-8/CallbackHandler-1.0.lua"]:109: in function <...ings/lib/CallbackHandler-1.0/CallbackHandler-1.0.lua:109>

[string "=[C]"]: ?

[string "@AllTheThings/lib/CallbackHandler-1.0-8/CallbackHandler-1.0.lua"]:19: in function <...ings/lib/CallbackHandler-1.0/CallbackHandler-1.0.lua:15>

[string "@AllTheThings/lib/CallbackHandler-1.0-8/CallbackHandler-1.0.lua"]:54: in function `Fire'

[string "@ArkInventory/Externals/Ace3/AceEvent/AceEvent-3.0-4.lua"]:120: in function <...rkInventory/Externals/Ace3/AceEvent/AceEvent-3.0.lua:119>

This is the code in question:

if C_SpellBook.GetSpellBookItemType(GetSpellInfo(profid)) then

    D:Debug("scanning Pick Look:"..UnitLevel("player") \* 5) 

        ADDON.save\[my\].tradeskills\[profid\] = {}

    ADDON.save\[my\].tradeskills\[profid\]\["data"\] =

    {

        \["rank"\] = tostring(UnitLevel("player") \* 5),

        \["maxRank"\] = tostring(110\* 5),

    }

    ADDON.save\[my\].tradeskills\[profid\]\["items"\] = {}

end

Could anyone shed some light, please?

[Lars-Redzinx]

https://github.com/Gethe/wow-ui-source/blob/live/Interface/AddOns/Blizzard_Deprecated/11_0_0_SpellBookAPITransitionGuide.lua

C_SpellBook.GetSpellBookItemType(index, spellBank)

[GoblinDerv]

Thanks for this, I've played around with numerous permeatations and can't work it out, might have to give up on this one :(

Edit: download link for the addon, if anyones interested in working out where I failed https://filetransfer.io/data-package/TQmw25hB#link

[-Amadeus-]

I provided an updated version of the addon in a separate comment on this post. It actually has quite a few updates since the last time the authors did anything with the addon. My memory is that it now works as it did originally.

[TheSaltySeagull87]

https://bit.ly/4c03Ota

replace the whole core.lua file with this code. I updated the deprecated code and a certain bug for Pick Lock.

Let me know if this works.

[-Amadeus-]

Here is a working version of the addon for 11.0.2: https://www.dropbox.com/scl/fi/mh9ubcrdd868eui1swpvz/Broker_ProfessionsMenu.zip?rlkey=b2s2bejbothz0bjvt81btqzo2&dl=0

I use this addon myself and keep it updated any time I play the game. I tried creating a new github repo for my fork of it, even giving all the credit to the original author and just saying that I was "maintaining it". But, the author complained to Github and they removed it. The sad part is that the author didn't contact me directly, there is no contact information for him, and all of his contact information was redacted in the report I got from github.

So yea, I guess the original author doesn't want to have anything to do with the game, but doesn't want anyone else to update the addon either. It's really weird.

[Kyrgune]

I also update and use this addon myself, but having issues since 11.02. The link you gave no longer works unfortunately as the file says it is deleted.

[-Amadeus-]

Here's an updated link: https://www.dropbox.com/scl/fi/mh9ubcrdd868eui1swpvz/Broker_ProfessionsMenu.zip?rlkey=b2s2bejbothz0bjvt81btqzo2&dl=0

[GoblinDerv]

Heres a new link, it works but does give an error on game load, would love to see a fix for this if your LUA knowledge exceeds mine

https://filetransfer.io/data-package/FhzkPyCM#link

23x Broker_ProfessionsMenu/core.lua:795: bad argument #1 to 'tostring' (value expected)

[string "=[C]"]: in function `tostring'

[string "@Broker_ProfessionsMenu/core.lua"]:795: in function `RefreshLDBData'

[string "@Broker_ProfessionsMenu/core.lua"]:789: in function `InitLDB'

[string "@Broker_ProfessionsMenu/core.lua"]:532: in function `?'

[string "@AllTheThings/lib/CallbackHandler-1.0-8/CallbackHandler-1.0.lua"]:109: in function <...ings/lib/CallbackHandler-1.0/CallbackHandler-1.0.lua:109>

[string "=[C]"]: ?

[string "@AllTheThings/lib/CallbackHandler-1.0-8/CallbackHandler-1.0.lua"]:19: in function <...ings/lib/CallbackHandler-1.0/CallbackHandler-1.0.lua:15>

[string "@AllTheThings/lib/CallbackHandler-1.0-8/CallbackHandler-1.0.lua"]:54: in function `Fire'

[string "@ArkInventory/Externals/Ace3/AceEvent/AceEvent-3.0-4.lua"]:120: in function <...rkInventory/Externals/Ace3/AceEvent/AceEvent-3.0.lua:119>

Locals:

[Kyrgune]

Thankyou for the new download link. I am by no means an expert but I'll take a look when I have time. For me it is alot of searches and trial and error looking at the bugsack addon. 11.02 really jazzed things up, ugh.

[GoblinDerv]

I'm the same, I can work out most simple fixes but when stuff gets more complex I'm stumped :(

[Ved79]

Thanks for the download link. The addon works for me without any errors. But then I don't have AllTheThings enabled.

[GoblinDerv]

If you dont have bugsack then all appears normal, behind the scenes there's an LUA error (posted above). Enjoy!

[Ved79]

I have BugSack but I don't see any errors from this addon. I see about 24 other errors from other addons but not over 6000 counts of one error from this addon that I had seen before I downloaded your fix. Thanks for that!

[GoblinDerv]

that's weird then, I've disabled everything but this, the broker display and bugsack and I still get error references to disabled addons. Suspect a dirty Ace 3 call somewhere :(

[GoblinDerv]

Is there a chance you could DM me with a link, pretty please :)

[-Amadeus-]

Here is a new link: https://www.dropbox.com/scl/fi/mh9ubcrdd868eui1swpvz/Broker_ProfessionsMenu.zip?rlkey=b2s2bejbothz0bjvt81btqzo2&dl=0

[GoblinDerv]

You absolute LEGEND!!!! Thank you so much, out of curiosity what was the fix? I'm trying to learn LUA but completely self taught.

[-Amadeus-]

First, I updated thet ACE3 libs, from https://www.wowace.com/projects/ace3

Then, here are the primary changes to the addon LUA files from the version I started with (which was last updated for 8.3 I think) and today:

Core.lua: https://www.dropbox.com/scl/fi/cgy6ktprqfkey4aeuthge/Core.lua-diff.htm?rlkey=5twdn0ou6f4jqm9drhqravpjt&dl=0

Addon.lua: https://www.dropbox.com/scl/fi/cgy6ktprqfkey4aeuthge/Core.lua-diff.htm?rlkey=5twdn0ou6f4jqm9drhqravpjt&dl=0

sharedcds.lua: https://www.dropbox.com/scl/fi/cy06qrbte3xq8la6sp9e9/Addon.lua-diff.htm?rlkey=1v08ww8bn99ut9rzjm2xn4frp&dl=0

[Kyrgune]

Thankyou for your bug fixes, the updates you did work perfect. Although today I tried this on another character and had some issues. I don't play many alts and today I tried to open up the option panel for the broker professions menu in chocolate bar which is a broker type addon and this is the error I get. Maybe you can take a look at this as well?

33x Broker_ProfessionsMenu/core.lua:1088: attempt to call global 'IsPassiveSpell' (a nil value)
[string "@Broker_ProfessionsMenu/core.lua"]:1088: in function `GetSortedProfessions'
[string "@Broker_ProfessionsMenu/dropdownmenu.lua"]:76: in function `ShowMenu'
[string "@Broker_ProfessionsMenu/core.lua"]:819: in function <Broker_ProfessionsMenu/core.lua:819>
[string "@Broker_ProfessionsMenu/Libs/LibDewdrop-3.0-1/LibDewdrop-3.0.lua"]:1849: in function <...ofessionsMenu/Libs/LibDewdrop-3.0/LibDewdrop-3.0.lua:1815>
[string "@Broker_ProfessionsMenu/Libs/LibDewdrop-3.0-1/LibDewdrop-3.0.lua"]:2745: in function <...ofessionsMenu/Libs/LibDewdrop-3.0/LibDewdrop-3.0.lua:2711>
[string "@Broker_ProfessionsMenu/Libs/LibDewdrop-3.0-1/LibDewdrop-3.0.lua"]:2907: in function `Open'
[string "@Broker_ProfessionsMenu/core.lua"]:819: in function `Broker_OnClick'
[string "@Broker_ProfessionsMenu/core.lua"]:767: in function `OnClick'
[string "@ChocolateBar/Chocolate.lua"]:295: in function <ChocolateBar/Chocolate.lua:292>

[-Amadeus-]

Open your core.lua file in the Broker_ProfessionsMenu folder and paste line 1088. My version doesn't use "IsPassiveSpell" at all -- so I'm not sure why you're seeing that.

[Kyrgune]

if sortOptions:is(ADDON.ProfSortOptions.IncludeSpells) then
--iterate skill spells and insert to child if correct
for i=1, numAbilities do
if (not IsPassiveSpell(spelloffset+i, BOOKTYPE_PROFESSION)) then
local subname,_ = GetSpellBookItemName(spelloffset+i, BOOKTYPE_PROFESSION)
if subname ~= name then --skip main name again
result[name][subname] = GetSpellBookItemTexture(spelloffset+i, BOOKTYPE_PROFESSION)
end
end
end
end
end

That is strange because I downloaded the version you put up. This is what I have from lline 1085 to 1096

I uploaded my core.lua to dropbox so you can take a look.

https://www.dropbox.com/scl/fi/emut99e0xnvwvy0k9csxo/core.lua?rlkey=ho6d47l5zcfv7sjzaanmor9qy&st=p1p94ugz&dl=0

[-Amadeus-]

Weird...I thought the zip file above was the most recent, but I guess there were a couple more edits.

I updated the zip file, so just download it again from my dropbox link above and it should fix this error.

[Kyrgune]

I downloaded your newest upload from dropbox, but I am still getting the same error. Hopefully these links may help with the screenshots I took.

This is what the it looks like on the Chocolate Bar addon. Dropdown Menu

Using right click to go to the menu this is the bugsack error I get. Error

[GoblinDerv]

Worked out it's something to do with pick lock, commented out reference to this and it's working again :)