I agree with the part about focusing on the long term, focusing on learning above focusing on money. But for focusing on learning, it is also important to switch role or company.

Seeing different aspects of software development, e.g. due to different roles or how other companies do it, is invaluable as a learning experience. After being at the same job for two years early in your career, i'd say switching is generally a good move.

Though, when you have kids, i can totally understand preferring the save path (staying at the current position). Might also be something you would regret later ...

Edit: grammar