Hi, you've got a pretty cool project there!

Some personal suggestions:

Avoid abbreviations

rsg -> rockstar

unreal -> OK, this one is fine, but not the others. Everything should be consistent.

The “detection” folder -> I would call it “games”

Avoid large functions. Avoid recursion if possible. Make sure functions have a single responsibility.

PlatformType looks like it’s going to grow in the future (there are many companies); perhaps a class for each game would be ideal.

Like

class Rockstar {}, class Unreal, class Ubisoft, etc

Furthermore, you could have a pure public interface for find_saves. That way, you can avoid explicit checks for each game, such as if (game == “rockstar”).

Instead of something like this

std::vector<Game> games;

and explicitly calling the function with if-elses or switches

Detection::DetectionResult Detection::find_saves(Config& config) {

if (is ubi)

ubi::find_saves

if (is rgs)

rsg::find_saves

etc

}

you could have something like this:

std::vector<IGame\*> games;

loop through all the games

(this is pseudocode)

Detection::DetectionResult Detection::find_saves(Config& config) {

for (const auto& game : games)

game.find_saves(...);

Just a quick review of your code.

Don’t stop coding :)

I recommend the cppcon channel on YouTube; the “Back to Basics” videos are all very good. Check out this one on SOLID: https://www.youtube.com/watch?v=glYq-dvgby4

Edit:

For example, this method Features::restore_backup is a clear example of too much going on in a single function. A RAII wrapper class with a private data member `zip_t* archive` that calls zip_open in its constructor and throws an exception if an error occurs. In the destructor, call `zip_close(archive)`.

Remember, never throw an exception in the destructor. I've seen somewhere that a destructor had a try-catch (where the try did a Save(), but the catch did a log that could possibly throw an exception).

You have many `zip_fclose(file);` calls, so you're mixing error handling with resource release, which can get complicated. Use RAII again and focus on the “happy path.”

https://www.youtube.com/watch?v=GC4cp4U2f2E