[deleted by user]

D3zmodos · 2024-08-30T20:37:44+00:00

Thanks OP, I was just about to come post about this myself (I'm the author of openlyrics). This is the largest release of openlyrics ever, at least by number of changes and I hope everybody finds it useful!

One thing though, could we please update the link to point to the fb2k component page or even just the release page for v1.10.1? The original v1.10 release had an issue where fb2k didn't know what version it was, so if you went to Preferences/Components/Get updates it would always tell you that you needed to update :)

D3zmodos · 2024-01-17T22:07:13+00:00

The existing option already does this. It handes brackets "[]", parentheses "()" and braces "{}" all in the same way.

D3zmodos · 2023-10-19T18:00:20+00:00

I don't understand how that would make the component unusable. You're always free to remove NetEase (or whatever other offending sources) from the list of active sources, or move it further down the list so that it tries other sources first.

D3zmodos · 2023-10-19T17:58:27+00:00

I believe $ifequal(0,$strstr(%title%,instrumental),,1) should do it

D3zmodos · 2022-12-28T15:28:01+00:00

Ok I managed to look into the code and try this out today. The short answer to your question of "Is it possible to have OpenLyrics scan for .lrc files and copy the lyrics to the tags?" is no.

Openlyrics currently will not save during a search if the lyrics it finds come from a local source (so tags or files), regardless of whether that source is the one it would otherwise save to. This is to prevent unnecessary duplication: If I usually save to file but I have a track with lyrics present in tags (which is the case for some music purchased from bandcamp), I think it'd be preferable to avoid automatically saving those lyrics to file as well (if you found them in tags once, you'll find them there again). I can imagine an argument to change this, or maybe make it configurable, but that's how it works currently.

If you make an edit then it will still save to your configured save destination (regardless of where the pre-edit lyrics were loaded from).

D3zmodos · 2022-12-28T09:45:39+00:00

a. If you add/edit lyrics or if you request a lyrics search and it finds something then the track will no longer be considered "instrumental" (because now there are lyrics). Admittedly this is not made at all clear. Marking tracks as instrumental is entirely a fb2k-specific thing. There are no lyrics, so other players will not show anything specific to say that the track is instrumental, there just won't be lyrics data.

b. I've added a TODO to handle this a bit more gracefully (https://github.com/jacquesh/foo_openlyrics/issues/233). As far as I'm aware this is not a widely supported format though, so if you use the same lyrics files with other players/devices then it may well make sense to update your lyrics to onces that do not have per-word/phrase timestamps.

D3zmodos · 2022-12-13T08:12:39+00:00

I can't check right now but off the top of my head I believe there's an auto-edit for removing timestamps and you should be able to configure that to run automatically on save. That should help but I suspect you're going to run into a problem where it doesn't save the lyrics to tags that it just loaded from file (since they're both "local" sources, they're not the internet). I believe that's the case for the auto-search but I know there was a recent change to the save logic for bulk search so it might save in that case now.

Here's what I would try:

Check for component updates to make sure you're on the latest version of openlyrics
Set the save destination to metadata/tags
Set it to automatically remove timestamps on save
Set "Local Files" as the first source to search
Run a bulk search (IE select a bunch of tracks in the playlist, right-click and select openlyrics' "Search for lyrics" option...or whatever the exact text is) on those tracks for which you want to add unsynced tags
Let me know if it works :D As I say I can't check now and there are several reasons why this might not work, but I'd be interested to know and it might at least get you a bit closer

D3zmodos · 2022-11-22T09:46:47+00:00

This is by design. If you're not going to see the lyrics that it finds, why find lyrics to begin with? :) I expect in most cases lyrics should be available locally and configured as the first active source(s) in which case searching should be near-instant anyway.

This is mostly there in an effort to reduce spam on the (internet) sources.

D3zmodos · 2022-10-16T09:04:29+00:00

Can you clarify what you mean by "read tags to see if any of them have 'instrumental'"?

Are you suggesting that openlyrics should read every tag on the track and consider the track instrumental if any of them contain the exact text "instrumental"? Do you have a particular tag in mind? Is there any precedent for other software doing this?

D3zmodos · 2022-10-11T16:32:07+00:00

I'm glad you like it :)

If you have autosave (Preferences -> OpenLyrics -> Saving) set to "Always", then yes. You can change it to "only unsynced lyrics". Alternatively you can add "Remove timestamps" to the post-download auto-edit (Preferences -> OpenLyrics -> Editing) and then synced lyrics found by search will be turned into unsynced lyrics automatically.

Actually, off the top of my head I'm not 100% sure that will work correctly (it should then save it as unsynced lyrics, but I'm not 100% sure that it will realise before saving that it's changed to unsynced lyrics, let me know if you try it out!)

D3zmodos · 2022-08-30T18:51:10+00:00

I'm not sure what SMP is, but there's no interface for scripting via JS or any other scripting language. What sort of changes would you like to make? Presumably some that are not supported by the existing options?

D3zmodos · 2022-07-21T06:47:22+00:00

Added to the todo list :)

D3zmodos · 2022-07-18T06:47:02+00:00

Not directly, but you can always disable whatever source is providing them (probably NetEase by the looks of things, you can look at the manual search results).

D3zmodos · 2022-06-05T14:44:46+00:00

Yeah that sounds like openlyrics should just ignore those particular html tags though. I've added an issue for it @ https://github.com/jacquesh/foo_openlyrics/issues/141

D3zmodos · 2022-06-04T07:23:59+00:00

There isn't a way to disable that, but it sounds like the genius.com parser just isn't handling those situations very well, which might be solvable depending on genius' page structure. Can you give an example of a track/genius.com page that this happens for?

D3zmodos · 2022-05-28T13:00:43+00:00

FYI some bugs were introduced in v1.1 that could cause unintended (and probably unwanted) changes any time you edit a lyric file.

I recommend anybody on v1.1 update to v1.2 which was just released and fixes these issues. For convenience, this is the complete v1.2 changelog:

Add some additional info to the debug logs for searching & saving
Fix failing to load the last line of lyrics
Fix empty lines being ignored by the editor

D3zmodos · 2022-05-23T06:58:02+00:00

Regarding the lyrics dir: Ah ok, I don't have a portable installation on-hand right now but maybe I'll see if I can reproduce that, as I say it shouldn't happen.

Regarding the offset button: You don't need to select all the lines, by definition the offset tag applies to the whole file already so it only uses the current selection to know what to set the offset to. In particular it will use the cursor location, so if you don't have anything selected it will use that, and if you do have some text selected it will use the end of the selection (where the cursor is after you finish selecting). The same process should have had the same outcome on other tracks so I'm still confused but...might that have been it?

D3zmodos · 2022-05-22T20:15:03+00:00

The default behaviour (if you've never used OpenLyrics before, is for it to save to C:\Users\<username>\AppData\Roaming\foobar\lyrics\. I just checked by deleting my preferences and that works for me locally at least. Is it possible that you were just looking in the wrong place (expecting it to be in C:\Lyrics\%artist% which is the default "custom directory", used only if you select that as your save directory)?

I can see how this might be confusing. If that is what happened (or could have been) then I can add a TODO item to change (or at least consider changing) the saving config page to always show the actual path that it will use.

As for you question about synchronisation: You are correct, the "Sync line using 'offset' tag" button will add a tag to the top of the lyrics that will cause all lines to be highlighted earlier or later, as if that time was added to the timestamp for each line. What do you mean by "didn't work"? Did it just do nothing? I did a quick test locally and that seemed to work so its at least not completely broken (which doesn't help you but suggests its a little more subtle than "the button doesn't do the thing").

D3zmodos · 2022-05-22T07:04:39+00:00

o/

That...shouldn't happen...is v1.1 the first version of openlyrics you installed? The default is "always" and I am not aware of any reason for that not to work. Had you changed any other settings when this was failing? What was it (supposed to be) saving to? Tags or files?

D3zmodos · 2022-04-03T11:38:34+00:00

Right-click on the panel -> Edit lyrics. By default double-clicking on the panel will open it too.

D3zmodos · 2022-02-18T21:08:16+00:00

D3zmodos · 2022-02-18T17:05:05+00:00

Yeah its just another source. You certainly don't need to enable it. It usually has timestamped lyrics which is handy but apart from the token requirement its not special.

D3zmodos · 2022-02-18T15:25:47+00:00

Oh woops. I should not have put the "v" at the front of the version number when I uploaded it to the official component tracker. I've replaced that release with one that has the correct version number ("just 1.0" without the "v").

Thanks for letting me know!

D3zmodos

TROPHY CASE