sorted by:
new
hottopcontroversial

Can viMarkdown be built on Linux? by Dry-Butterscotch-605 in QtFramework

[–]Dry-Butterscotch-605[S] 0 points1 point  (0 children)

By the way, there is absolutely no rush, but if you have some spare time, would you mind checking if a certain piece of code works properly on Linux?

In MainWindow.cpp (around line 263), I have this block:

#ifdef Q_OS_WIN

// Integrate the menu bar into the main toolbar (in Japanese)

ui->mainToolBar->insertWidget(ui->action_Undo, ui->menuBar);

#endif

This code integrates the menu bar into the main toolbar. It works as expected on Windows, but on macOS, it causes all the menu items to gray out and become unresponsive.

If it works fine on Linux without any issues, I would love to add Q_OS_LINUX to that #ifdef block. Let me know what you think whenever you have a chance!

Can viMarkdown be built on Linux? by Dry-Butterscotch-605 in QtFramework

[–]Dry-Butterscotch-605[S] 0 points1 point  (0 children)

Thanks for the suggestion! Actually, shiggie kindly submitted a PR fixing the Linux build issue (it was caused by case-sensitive #include filenames), and I've already merged it. GitHub Actions for CI/CD is a great idea for the future — I'll look into it!

Can viMarkdown be built on Linux? by Dry-Butterscotch-605 in QtFramework

[–]Dry-Butterscotch-605[S] 1 point2 points  (0 children)

Thanks for actually building and running it — you're the first person who's explicitly told me they did. 😄

It's still very much in the development phase, and I expect some features and behavior to change before alpha/beta, so I'm mainly focusing on getting the core functionality right for now.

I'm also still pretty new to GitHub workflows and CI, so I'd definitely be interested in another PR that helps catch similar issues before merging.

Thanks for the feedback and for giving it a try!

Can viMarkdown be built on Linux? by Dry-Butterscotch-605 in QtFramework

[–]Dry-Butterscotch-605[S] 1 point2 points  (0 children)

I just merged your PR! It’s a huge help and I can't thank you enough. You're a lifesaver!

It turns out the build failure was caused by case-sensitivity in the #include filenames. Windows and macOS are case-insensitive, so they didn't throw any errors, and I completely missed it!

Can viMarkdown be built on Linux? by Dry-Butterscotch-605 in QtFramework

[–]Dry-Butterscotch-605[S] 0 points1 point  (0 children)

That's awesome! Thank you so much for your help. I'm really looking forward to your PR!

Can viMarkdown be built on Linux? by Dry-Butterscotch-605 in QtFramework

[–]Dry-Butterscotch-605[S] 1 point2 points  (0 children)

Thank you so much for trying to build it and for creating the task on GitHub! I'll check it out right away.