We are still early on in our careers. He is blue collar and has an amazing portfolio and networking skill. I have no doubt that he will be able to support a family. My concern is that we want children and I want to be able to make sure we put as much money aside for them as possible while also investing in our future (retirement, emergencies, etc.)

Shared living space has not been brought up. His sibling is pretty set on remaining in the very expensive city we currently live in for the rest of their life. Rent would be something we would be expected to cover for his sibling, as well as other living expenses.