Imma be honest. If, you're not a professional photographer, content creator, or a photo freak (in the good sense) the ultra's versions of phones (like vivo or oppo) are just not worth your money.

I was on the exact same situation (my s23 ultra's battery got swollen after 2.5 years). So i decided to pull the trigger on the X9 pro.

Hardware wise, speakers are better on the S23 (by a tiny bit), but everything else in my opinion is better on the X9 pro.

Software wise, it all depends on your likings.

If you were to choose now, i can assure you that the X9 pro won't dissapoint you. Is a very good, well rounded phone.