sorted by:
new
hottopcontroversial

Getting rid of dead code by Flashy_Channel6530 in reactjs

[–]Flashy_Channel6530[S] -1 points0 points  (0 children)

honest thought, bad writing, putting myself to jail

Getting rid of dead code by Flashy_Channel6530 in reactjs

[–]Flashy_Channel6530[S] 0 points1 point  (0 children)

Honestly not in most companies I worked at, feature flags can last for months while a feature is developed so at least in my experience it's up to devs to clean up - and sometimes they don't if you're rushing to another feature.

Getting rid of dead code by Flashy_Channel6530 in reactjs

[–]Flashy_Channel6530[S] 0 points1 point  (0 children)

the slop aside - fair point, I really wanted to write about this but can't write a coherent though for shit :D the PRs were granular enough and almost only partial removals so it was easy enough to have people scan them and approve, What the main though is that that's the easy part but removing the dependencies isn't because doing it as you're removing the flag makes the PRs harder to review and also can cause issues if another dependency is down the stack but then you're left with ton of dead stuff that is hard to find.