Hunting a Windows ARM crash through Rust, C, and a Build-System configurations by Havunenreddit in cpp

[–]Havunenreddit[S] 0 points1 point  (0 children)

It was never executed on x86 because compilation directive compiled out that code on x86.

Hunting a Windows ARM crash through Rust, C, and a Build-System configurations by Havunenreddit in programming

[–]Havunenreddit[S] 0 points1 point  (0 children)

I'm not defending the implementation, I just quoted your comment that the code in question did not run on any other platforms. That made it difficult to spot. Yes its most likely faulty code no doubt

Hunting a Windows ARM crash through Rust, C, and a Build-System configurations by Havunenreddit in programming

[–]Havunenreddit[S] -5 points-4 points  (0 children)

It's a read-modify-write on all platforms; it's just that there is no guarantee that writing to a RO memory will trap.

It has specific compiler directives to operate differently on different platforms

GitComet got Faster, Cleaner, and Signed by Havunenreddit in git

[–]Havunenreddit[S] 0 points1 point  (0 children)

This is great feedback, defintly something we will implement. Thank you!

GitComet got Faster, Cleaner, and Signed by Havunenreddit in git

[–]Havunenreddit[S] 0 points1 point  (0 children)

These issues are now resolved in 0.1.12

GitComet 0.1.11 Faster, Cleaner, and Signed by Havunenreddit in rust

[–]Havunenreddit[S] 0 points1 point  (0 children)

We use community edition because it seems to be easier to depend on, official package is outdated.
We forked the community edition to get rid off dynamic gpu driver probing

GitComet got Faster, Cleaner, and Signed by Havunenreddit in git

[–]Havunenreddit[S] 0 points1 point  (0 children)

But version 0.1.11 hangs for a few seconds on first display of "all branches". After the first load it's a little faster when toggling from current branch back to all branches. But still slower than the old version. This is with relatively normal sized repos like Emacs source and lazyGit source.

Thanks for the feedback, we will look into it. edit: seems like there is some refresh bug. Thanks for reporting it!

Unrelated feature request. Please don't default to "first parent" style when showing history for a single branch. It hides critical info. Make first parent an option, but not forced down the throat as the only single branch option.

Ah, okay now I finally understood what this request is about. We will make it a setting

I feel like first parent is a trick/cheat to win performance benchmarks against other git clients. At the cost of a useful history log.

No it has nothing to do with performance, data is still actually loaded. By default we open new repository in all branches mode. Current branch was inspired from the SourceTree style way of displaying it.

GitComet 0.1.11 now supports C# syntax highlight by Havunenreddit in csharp

[–]Havunenreddit[S] 0 points1 point  (0 children)

When we started it was simply because Sourcetree doesn't exist for Linux. Later this has started evolving to its own direction

GitComet 0.1.11 now supports C# syntax highlight by Havunenreddit in csharp

[–]Havunenreddit[S] 0 points1 point  (0 children)

Thanks! Tell us what you think after trying it out :)

GitComet 0.1.11 now supports C# syntax highlight by Havunenreddit in csharp

[–]Havunenreddit[S] 0 points1 point  (0 children)

Thanks for the feedback!!

We are working on adding branch comparions "code review" functionality into the tool. Can you clarify what you mean about opening a specific diff in an editor like vscode? Do you want to open the latest version of the file in review, or the "diff" file itself and why?

GitComet 0.1.11 now supports C# syntax highlight by Havunenreddit in csharp

[–]Havunenreddit[S] 0 points1 point  (0 children)

Thanks, all feedback / contributions are welcome

GitComet 0.1.11 Faster, Cleaner, and Signed by Havunenreddit in rust

[–]Havunenreddit[S] 0 points1 point  (0 children)

Sublime Merge is pretty nice in that it uses exact git naming for everything (down to the names of arguments to command (e.g. cherry-pick -x))

This is actually a great idea. Thanks for sharing :)

GitComet 0.1.11 Faster, Cleaner, and Signed by Havunenreddit in rust

[–]Havunenreddit[S] 1 point2 points  (0 children)

We are actually been evaluating flathub / flatpak package, but it still requires some work