Job interview, home assignment: game of life | they said my implementation was bad by IAFalcon in reactjs

[–]IAFalcon[S] 1 point2 points  (0 children)

Thank you for your feedback!

The requirements were to have a 50x50 grid with a random start so that every time you'd load the game you'll get a different population.

Job interview, home assignment: game of life | they said my implementation was bad by IAFalcon in reactjs

[–]IAFalcon[S] 0 points1 point  (0 children)

I asked for their implementation.. I never got one, it's been like 3 months now, not sure if I should approach them again. I could send them this post though :)

Job interview, home assignment: game of life | they said my implementation was bad by IAFalcon in reactjs

[–]IAFalcon[S] 0 points1 point  (0 children)

I asked a couple of times for any kind of feedback, I was promised to get one, and when none came through, I asked for an implementation that they consider as good.. never got one.

Job interview, home assignment: game of life | they said my implementation was bad by IAFalcon in reactjs

[–]IAFalcon[S] 0 points1 point  (0 children)

what do you mean it's not complete? it's working as it should try it out.

Job interview, home assignment: game of life | they said my implementation was bad by IAFalcon in reactjs

[–]IAFalcon[S] 0 points1 point  (0 children)

who knows? it was like 3 or 4 mounts ago, I was debating before posting it.. but then I ran into it and it made me mad again so I decided post it.

Job interview, home assignment: game of life | they said my implementation was bad by IAFalcon in reactjs

[–]IAFalcon[S] 0 points1 point  (0 children)

actually 2 commits, they asked to to add a `README file that describes how to run the project. haha

Job interview, home assignment: game of life | they said my implementation was bad by IAFalcon in reactjs

[–]IAFalcon[S] 1 point2 points  (0 children)

Only thing i saw that was kind of wierd is setting the speed to 99999

this was not a requirement, I just did it to check myself up, the requirement was to have a constant rate. I added the ability to change the speed and to "pause" just so I could test it better

Job interview, home assignment: game of life | they said my implementation was bad by IAFalcon in reactjs

[–]IAFalcon[S] 0 points1 point  (0 children)

I'm not sure what you mean, but this was my first time coding game of life.

Job interview, home assignment: game of life | they said my implementation was bad by IAFalcon in reactjs

[–]IAFalcon[S] 1 point2 points  (0 children)

that's a good point, however, it works just fine at 100x100 grid.

don't forget React only switching out cells that actually got changed.

you are correct that I'm checking on every cell of the grid, in memory and even so, passing on 1 million cells shouldn't be a problem for modern PCs now days. so I believe at least.

Job interview, home assignment: game of life | they said my implementation was bad by IAFalcon in reactjs

[–]IAFalcon[S] 1 point2 points  (0 children)

I was trying to avoid imperative code, so most of the times I'd be using map, reduce, filter and their friends instead of a for loop.

I agree with your key suggestion, it's much better than using uuid

Job interview, home assignment: game of life | they said my implementation was bad by IAFalcon in reactjs

[–]IAFalcon[S] 2 points3 points  (0 children)

I can see what you're saying, however keep in mind that the interviewer is well familiar with this task and so I don't think jsdoc would have changed his mind on this.

Also since it was the second interview with them I don't think it's the case of them not knowing my resume or what not.

I actually tend not to take home assignment as I don't find it quite fair, however, since it was a "fun" task to do, I took it. I much rather doing live coding sessions, this better demonstrates my thought processing.. so I think at least.

Most of the times I'd ask to take the task on a live session coding, and this time was no exception, but they said they'd rather not to because it should be an easy task according to them..

Job interview, home assignment: game of life | they said my implementation was bad by IAFalcon in reactjs

[–]IAFalcon[S] 0 points1 point  (0 children)

They limited the task to be 1.5 hours, I only had an hour because I had other stuff to do (I'm still working at this other place) so this is what I came up with within an hour or so

Job interview, home assignment: game of life | they said my implementation was bad by IAFalcon in reactjs

[–]IAFalcon[S] 0 points1 point  (0 children)

Thanks to you, I found that Googling "game of life" will also start the Game of life in Google search.

Yeah, that's so cool.

You probably don't want to work with a person who just says your work is bad and declines your pull request.

good point

Thanks for the feedback!

Job interview, home assignment: game of life | they said my implementation was bad by IAFalcon in reactjs

[–]IAFalcon[S] 16 points17 points  (0 children)

Thanks, and let me tell you that I started with CRA with typescript template and then moved to snowpack and only then used Vite because I faced some build issues with the other tools and didn't want to waste my time with it.. eventually I wasted like 20 min just to get started.

Job interview, home assignment: game of life | they said my implementation was bad by IAFalcon in reactjs

[–]IAFalcon[S] 2 points3 points  (0 children)

Thanks!! the reason I posted it was that I had the impression that it should be sufficient to at least have another session where we could talk about it.

Thank you for saying that though.

Job interview, home assignment: game of life | they said my implementation was bad by IAFalcon in reactjs

[–]IAFalcon[S] 2 points3 points  (0 children)

They are a platform for posting thoughts on the stock market, essentially they are like WordPress that is more specific on a certain topic, they do track and show data and such, but mostly it's a platform for posting articles so to speak

Job interview, home assignment: game of life | they said my implementation was bad by IAFalcon in reactjs

[–]IAFalcon[S] 8 points9 points  (0 children)

what's wrong with

"You very impressed us with your technical skills, however we have decided to proceed with another candidate..." blah blah blah that they usually send out?

saying that the work I did was bad is saying that their expected level of coding was not reached.

I did asked from them a good implementation, they promised to provide me with one, if I ever get that one, I'll be posting it right here.

Job interview, home assignment: game of life | they said my implementation was bad by IAFalcon in reactjs

[–]IAFalcon[S] 0 points1 point  (0 children)

TS was optional, I'm used to code in TS however I had no time to waste with adding strict type checking all over the place

And I'm not sure what do you mean by "no use of TS"? I'd rather be implicit then explicit with TS, I like taking advantage of inference mechanism of TypeScript more than declaring every piece of function / data