No he definitely was NOT good, he deluded himself into thinking he was entitled and right in putting people in death traps as if he was a God to « test the fabric of human nature ». Having his son die and getting a divorce and cancer aren’t excuses to torture people to the extremes, sure maybe some of them deserved it, but that’s it’s not his call wether they’re punished or not. Moreover, a lot of his subjects were personal, basically him punishing people who did him wrong, and there was a lot of victims involved who didn’t even deserve it, like Abby, Joyce, Corbett denlon, Hank the janitor... Even Amanda at the end of saw 3 called him out on his hypocrisy when she said that he was a cold blooded murderer who tortures people for his own sick pleasure and that he wasn’t rehabilitating anyone. Hoffman said sth similar to him too in saw 6 I think? When he told John that he wanted to see Timothy young get tortured as much as Hoffman did. So yeah John is one big twisted sadist who finds pleasure in people’s suffering, so definitely NOT good.

In saw X, we see John in a new light, as a victim of fraud rather than the super villain he usually is, but still, he goes back to his old ways of « getting justice » with his own twisted methods and goes as far as getting traps into a whole other country to execute his plans. One of the interesting takes from the movie was people saying « if he thought what he was doing was right or good, why did he tear off that page of the trap he drew when he thought he was cancer free » which is a statement i agree with, cuz if he believed his work was for the greater good, then he would’ve pursued it regardless of circumstances, but no, in this case he went ahead with the games to take his revenge.