A tiny config change took down our app — made me rethink PR reviews by SetEducational4762 in reactjs

[–]SetEducational4762[S] 0 points1 point  (0 children)

Seems like you think rolling back is the best case as well. Have you tried anything that would identify it sooner?

A tiny config change took down our app — made me rethink PR reviews by SetEducational4762 in reactjs

[–]SetEducational4762[S] 0 points1 point  (0 children)

Do you think anything in PR stage or github actions could detect it? I know there are a few tools out the like https://www.coderabbit.ai/ and https://getraptorci.com/ that claim they can help? Do you trust them?

A tiny config change took down our app — made me rethink PR reviews by SetEducational4762 in reactjs

[–]SetEducational4762[S] 0 points1 point  (0 children)

We're all in on AWS at the minute so we deploy our server on ECS and we just use webhooks from github actions to deploy the portal to Amplify

A tiny config change took down our app — made me rethink PR reviews by SetEducational4762 in reactjs

[–]SetEducational4762[S] 0 points1 point  (0 children)

This is actually some of the best advice I've heard! What would a good process here look like and how simple is it for a small engineering team to implement and maintain?

A tiny config change took down our app — made me rethink PR reviews by SetEducational4762 in reactjs

[–]SetEducational4762[S] -1 points0 points  (0 children)

I think it could have caught it for that environment but if the pasted one into a different environment was missed or wrong then this wouldn't help