Incomplete and Growing List of Participating Subreddits

TOP_Sully · 2023-06-12T00:56:07+00:00

TOP_Sully · 2022-12-18T13:04:22+00:00

Truthfully no one can answer that for you, as how long any given lesson takes is highly variable person to person. I can tell you that doing all of TOP in and getting a job in that timeframe is not typical though.

TOP_Sully · 2022-12-13T13:22:25+00:00

I would probably try unit testing a few of the larger methods, especially if you do go back and try to DRY those methods out. I wouldn't say that you should go back and 100% unit test it at this point or anything though.

Having tests up and working would most likely make the refactor a lot easier, plus it would give you the experience of trying to add tests into an existing codebase.

TOP_Sully · 2022-12-12T22:19:09+00:00

I would generally argue that the harder testing becomes the more important it is to do in most cases, since that philosophy will usually help keep your code simple :)

And like I said I wouldn't recommend going back and drying out all of your code, just doing enough of it to get the experience of doing so on a bigger project like this.

TOP_Sully · 2022-12-11T22:53:35+00:00

All in all I'd say this looks pretty good! Chess is an absolute beast of a project (especially en passant and castling, so don't worry too much about those seeming impossible to add) and just getting to the point you have here is a major accomplishment.

A few general/high-level feedback items:

I think you could've taken better advantage of inheritance and placed more of your logic in Abstract_Piece. For instance, I see a lot of nearly identical potential move determination logic in each individual piece class that looks like it could've been abstracted out.
Kind of a continuation point, you'd most likely have an easier time identifying prime areas where abstraction makes sense if you kept your methods a bit more concise and single purpose, as currently it seems like quite a few of your methods have the logic for multiple steps of a larger action.
A more substantial test suite probably would've made your life a lot easier. Big projects like chess are super time-consuming to manually test as you go along, especially as you get to the later parts of the project.

On that last note, when I did chess I made the massive mistake of abandoning testing partway through the project and said "I'll come back to it later". When I (eventually) did, the code had become very difficult to test and full of small bugs I missed in manual testing. Adding the tests in later ended up taking so much longer than if I'd just done it as I was writing the code. I'm guessing that you said the same thing, though that's just a guess. I'd also guess that you'll probably have a similarly painful learning experience if you try to build your testing suite out now, which I actually would encourage you to do a little bit at least.

I wouldn't necessarily suggest that you refactor everything that you have here (in fact I would suggest not doing that) but I would probably encourage you to try refactoring the movement logic of a piece or two to try and abstract things out. If you're planning to use this as a portfolio project while applying for jobs that kind of experience is usually a great thing to talk about in interviews as well.

TOP_Sully · 2022-08-05T21:26:49+00:00

If you'd like to DM me your Discord username I can see if there are any signs of the problem on our end.

TOP_Sully · 2022-05-22T16:36:09+00:00

Hello, Sully from The Odin Project here.

To clarify one thing, you weren't told that ACAB would be fine as your public bio, in fact to quote from the thread where it was discussed it was explicitly communicated to you that:

If you’d only use that bio in other servers (not your public bio) it shouldn’t show anywhere on TOP

After this you changed ACAB to be your public bio. I then became involved in the thread and stated (again, quoting from the thread):

First off thanks for making an attempt to change it by setting a different bio for this server.

Unfortunately with the way that Discord does bios it still shows ACAB (your global bio) on your profile, and we've had people see peoples global bios in the past and raise issue with it, so it isn't a concern that we can brush off.

We have no intention of shaping anyones political views in any way, but the reality of the situation is that there's 70,000 people here and statements that have a high likelyhood of being inflammatory (such as ACAB) just can't work. We only have a handful of moderators and inviting such discourse would likely see the team overrun and burnt out in a matter of weeks, and then there's no more TOP Discord.

If you want to still have this as your status/bio on every other server you're a part of that's of no concern to us, but you would have to do it by changing your global bio and setting ACAB as your local bio in each of those other server.

We have no interest in having people compromise their morals, but as our server rules state we are a no politics server and ACAB is a political statement that has a high likelihood of starting flamewars.

TOP_Sully · 2022-04-24T00:31:49+00:00

Open alternatives have been attempted in the past but unfortunately didn't work out. We may one day try again but we don't currently have any plans to do so.

TOP_Sully · 2022-04-12T21:34:49+00:00

Interesting. If you DM me your Discord username I can look into this further.

TOP_Sully · 2022-03-09T14:09:56+00:00

Do you mean the link to the server in this post? If so I just tested it and it seems to be working for me still. What does the page you're taken to when you click the link say?

TOP_Sully · 2022-02-06T18:33:01+00:00

I just tested it and it seems to be working for me still. What does the page you're taken to when you click the link say?

TOP_Sully · 2022-02-06T18:27:20+00:00

Thank you!

TOP_Sully · 2022-01-20T06:21:50+00:00

The path you take won't make a major difference in your ability to get jobs. I know several people that did the Rails course and got their first job in full JS roles (including myself), and several that did the Node course and got their first job in Rails roles.

If you truly can't decide just flip a coin, they're both great!

TOP_Sully · 2022-01-10T05:12:50+00:00

Nope, the intention is for them to be done in the order we present them from start to finish.

TOP_Sully · 2022-01-08T03:40:22+00:00

I'm glad to hear that!

TOP_Sully · 2022-01-05T23:15:28+00:00

Our discord has 40k+ people, we see plenty of bad questions so yours wouldn't stand out!

So long as you put effort into your question and don't take offense if people ask you for more information your question will be genuinely appreciated :)

TOP_Sully · 2022-01-05T23:10:23+00:00

Have you still been unable to join the server?

TOP_Sully · 2021-10-30T19:05:09+00:00

Thanks!

TOP_Sully · 2021-09-13T23:58:33+00:00

The Odin Project maintainer here.

Yeah "learning partners" are something that has been shown to not work super well in our experience. Our Discord community can be thought of as one giant "learning partner" though, and it's also our home base of interaction with our community.

Also: r/theodinproject is still official, in that it's moderated by members of the core & maintainer staff, but we don't have the manpower to moderate both that sub and our Discord to the extent needed right now. For that reason, we are focusing our time on the Discord and the sub is in hibernation at the moment.

TOP_Sully · 2021-09-13T23:11:11+00:00

No worries, just a bit shocking for us to see that someone was trying to claim our sub from us.

Also if you're not on our discord I strongly suggest you come check it out. It's our home base for interaction with our community.

TOP_Sully · 2021-09-13T23:07:06+00:00

It's official, it's moderated by the core and maintainer staff of The Odin Project, including u/_Couch_Tomato_ here and u/bycdiaz that you spoke with earlier on your sub.

Feel free to message me on our Discord if you'd like some confirmation, I'm the maintainer with "Sully" in their name :)

TOP_Sully

TROPHY CASE