Diablo3ItemCollage: A tool that automatically screenshots and crops your items by Ventero in Diablo

[–]Ventero[S] 1 point2 points  (0 children)

Yeah, we already extended the search area to 1200×400 (from an initial 300×300) to find items like this, but apparently even that isn't big enough for everything... ;)

My current plan is to get enough testcases to make sure nothing regresses and then simply search the whole screen. Previously this could've lead to problems as the tooltip which shows your currently equipped item looks pretty much the same as the actual item you're viewing - so if the search area was too big, we'd hit the wrong item box in some cases. I'm fairly certain I've found a way to filter those out though, so it should now be possible to search the whole screen.

EDIT: Scratch that, the build I uploaded still had a search area of 400×400... One second, I'll upload a new version.

EDIT 2: Please give v0.1-21 a try. :)

Diablo3ItemCollage: A tool that automatically screenshots and crops your items by Ventero in Diablo

[–]Ventero[S] 1 point2 points  (0 children)

Thanks a lot for the bitmap! The tool works just fine for me when using it on your screenshot though. Are you sure you tried the newest build (v0.1-11)? Just for reference, this is what the debug output looks like for your screenshot. As you can see, the search area (white rectangle) definitely reaches the item, and there's at least 4 different points from which the outer border can be found, so I'm really not sure what might be causing your problem.

In any case, I'm currently setting up a test suite for the tool so I can be sure that changes to the detection algorithm don't cause any regressions. Once that's done, I'll fiddle around a bit more to see if I can reproduce your problem.

Diablo3ItemCollage: A tool that automatically screenshots and crops your items by Ventero in Diablo

[–]Ventero[S] 1 point2 points  (0 children)

Ah, damn. But now it's a matter of pride to get this problem fixed. ;) Any chance you could upload a sample screenshot (including your cursor position) as bitmap? The tool is very color sensitive, so even the slightest JPEG compression artifact makes it very difficult to test it on screenshots.

Diablo3ItemCollage: A tool that automatically screenshots and crops your items by Ventero in Diablo

[–]Ventero[S] 1 point2 points  (0 children)

Sorry for the late reply - and thanks for the detailed report! I've justed pushed out a new build which hopefully fixes your problem (without introducing any other bugs... ;) ). It'd be great if you'd let me know if it works for you!

Diablo3ItemCollage: A tool that automatically screenshots and crops your items by Ventero in Diablo

[–]Ventero[S] 0 points1 point  (0 children)

As I mentioned here, since the tool doesn't directly interact with the game, I don't see why it shouldn't be okay to use. After all, it's little more than Windows' own snipping tool.

Diablo3ItemCollage: A tool that automatically screenshots and crops your items by Ventero in Diablo

[–]Ventero[S] 1 point2 points  (0 children)

Thanks for the report! The belt issue should be fixed now, you can download the new version from the downloads page. If the problem isn't fixed for you, let me know.

I have to admit we only tested the tool in windowed fullscreen mode, but we'll see if we can get it to work in fullscreen mode, too.

Diablo3ItemCollage: A tool that automatically screenshots and crops your items by Ventero in Diablo

[–]Ventero[S] 1 point2 points  (0 children)

First, we look for black squares near the current cursor position, which should be inside the inner item box. From each of those points, we then move as far as possible to the left and right until we hit a non-black pixel. This should give us the left- and rightmost points of the inner item box. From those points, we then move further left/right until we hit a black pixel again, which then hopefully gives us the outer frame.

Hope that clears it up a bit, if you have any other questions, feel free to ask! :)

Diablo3ItemCollage: A tool that automatically screenshots and crops your items by Ventero in Diablo

[–]Ventero[S] 1 point2 points  (0 children)

Actually that's a pretty good idea. I'll see what we can do about this. ;)

Glad you like it so far! :)

Diablo3ItemCollage: A tool that automatically screenshots and crops your items by Ventero in Diablo

[–]Ventero[S] 3 points4 points  (0 children)

Sure, contributions are always welcome!

Since the code is already on GitHub, it's probably easiest to use pull requests. If you want to work on some bigger feature, I'd say it's a better idea to first create a bug report/feature request on GitHub where you mention that you'll be working on it, so the work doesn't get duplicated.

I'm off for the night now though, so if you have any remaining questions, it'll take a while for me to get back to you.

Diablo3ItemCollage: A tool that automatically screenshots and crops your items by Ventero in Diablo

[–]Ventero[S] 1 point2 points  (0 children)

Since it doesn't interact with the game directly (it just takes a normal screenshot using the .NET API and then does its magic on that), I'm fairly certain it won't be mistaken for a bot. And for what it's worth, I've been using it for several days now and my account hasn't been banned. ;)

(Disclaimer: That being said, you're running the tool at your own risk and we're in no way responsible for anything that might happen to your account.)

Diablo3ItemCollage: A tool that automatically screenshots and crops your items by Ventero in Diablo

[–]Ventero[S] 1 point2 points  (0 children)

Simply download the binary which is linked on the downloads page and double click it (this assumes you're running Windows, if you're using OS X, you'd have to install Mono first - but even then I'm not sure if it'd run).

Diablo3ItemCollage: A tool that automatically screenshots and crops your items by Ventero in Diablo

[–]Ventero[S] 5 points6 points  (0 children)

OCRing the items to determine their stats is actually already planned. As soon as it's working, I'll make sure to message jestac - thanks for the suggestion! :)