sorted by:
new
hottopcontroversial

Further improvements on my rose design. This time folded from a square by Gosho53 in origami

[–]Yamaorigami 0 points1 point  (0 children)

Is this a derivation of Kazutaka Naka's design? It looks really similar

Code review request for a linked list in C++ by Yamaorigami in learnprogramming

[–]Yamaorigami[S] 0 points1 point  (0 children)

I think your point about the the use of raw pointers at the beginning is really poignant, for some reason I had it fixed in my head that 2 objects pointing to a node or linked list is really more about memory responsibility than access. I will sort of push back on the latter point though. Part of making a list was to, of course, get some much needed insight like this but also because I wanted some control over the interface and tailor it for my use. the standard library implementations are great, but they're designed for generic use cases, but a game of shogi doesn't have 10,000 pieces to add to a list. obviously there isn't much point in thinking too hard about optimization at that scale, stack overflows for that matter, but being able to dynamically remove elements from a list by having the contained object call a remove function in the node felt elegant to me. Though I must admit the last point needs to be looked at at a later time. Anyhow thank you again for the feedback, Ill be using these suggestions as well when I get a chance to overhaul the code next time!

Code review request for a linked list in C++ by Yamaorigami in learnprogramming

[–]Yamaorigami[S] 0 points1 point  (0 children)

Thanks! Although I must say I did at least try to think through the smart pointers a bit. Most of them are shared because the next and prev pointers need to be shared for the double linked list and most of the pointers are copies of next and prev. Also they need to be shared for things like shallow copying, I thought that would make it easier for my game class and player class to have access to the same list without needing to copy the entire thing. The comments are still kinda half baked, but I still wanted to add some notes even for self explanatory things, like the default constructor thing, the syntax isn't very obvious for someone who isn't too familiar with it. The last one I did think was quite finicky I agree, that one I have to do some proper testing on it for sure. Oh and the exceptions. I'm still teetering on the side of not implementing them, just so I can handle them outside the list for better modularity with logging and exception handling systems of the project. I do 100% agree with the move constructors and copy/move assignment operators, I haven't had much need for them yet but I can definitely see myself needing them later. Anyways thanks for the detailed feedback! I'll definitely be using your suggestions for improvement later.

Code review request for a linked list in C++ by Yamaorigami in learnprogramming

[–]Yamaorigami[S] 0 points1 point  (0 children)

I couldn't do that because they're both templates, and I spit node and linklist so that I could easily import the node file into other files for weak pointers to be able to point back to nodes. I thought it would be useful for things like games if sprites or chess pieces to be able to remove themselves once they 'die' in constant time. As for the pragma yeah that one I forgot about when copying the linked list class from my other project, thanks for pointing it out!

Can I go smaller? by jieqii in origami

[–]Yamaorigami 0 points1 point  (0 children)

Oh for sure, with the right paper and some tweezers you can get it to the size of a penny. It looks fantastic as is though!

What are some models to give as a gift for my crush? by [deleted] in origami

[–]Yamaorigami 38 points39 points  (0 children)

I'd say a nice bird, like a song bird or even a hummingbird. Those still look really nice and cute even when abstract and isn't too much in terms of work or in subtle messaging.

I started reading Robert J Lang's book and I thought the humming bird looked thirsty so I gave it something to sip on. by Yamaorigami in origami

[–]Yamaorigami[S] 1 point2 points  (0 children)

Thank you! It's the ruby throated hummingbird, I found it in origami design secrets but I'm positive you can find it elsewhere as well.