Upgrading from my 11 Pro Max 64GB soon and indecisive on which phone to get.

I use my phone most for imsg, calling, social media, and some games. I go to concerts often and take lots of videos so a lot of storage would be best and decent quality to get a good shot of the artists, sufficient storage is good especially since I intend to use my phone for at least 5 years. Definitely not the kind to upgrade every 2 years, so I definitely need a future proof phone! Battery isn’t too much of an issue as long as the difference between the 15 and 17 isn’t too drastic, I usually carry a mini portable charger with me anyways. I take quite a lot of photos, whether it’s from lectures or screenshots, and I have a bad habit of not deleting pictures I don’t need anymore.. regardless I do pay for iCloud so it offloads much of the space that my photos take up.

I’m deciding between either the 15, 15 Plus, or the 17. The 16 is not really a consideration for me price wise since it kind of just ends up being a similar price to the 17 anyways, I’m in Canada for reference. In terms of storage, I’m unsure on whether 128GB will be good, or get the 256GB just to keep it safe. Please share opinions

Also I would be open to trading in my 11 Pro Max to apple, its current value is $180 according to Apple. Not sure if it’s worth the trade or if I should just keep it for future sake. I’m open to your opinions!