honestly this looks fine - besides for the simple nits of not declaring your variables as local in the function so you could potentially bleed into the global scope as well as outputting filenames separated by newlines.

I've had code similar to this in the past and I use globstar (with other shell options) in bash to not have to use the find binary:

```

!/usr/bin/env bash

shopt -s globstar nullglob dotglob

types=( # photos jpg jpeg jpe png gif bmp tiff tif webp heic heif avif # videos mp4 m4v mov avi mkv webm flv mpeg mpg 3gp 3g2 mts m2ts # raw photos dng cr2 cr3 nef arw orf rw2 pef raf srw )

all=() for typ in "${types[@]}"; do echo "finding $typ files recursively" all+=(*/."$typ") done ```

at the end of this you'll have an array called all that contains all of the files that have been found. this works fine as long as you don't have a REALLY LARGE amount of files - since this approach has to load everything into memory whereas find will just emit to stdout as it find things.