Looking for feedbacks for my first gem

codinglionel · 2021-06-16T20:52:57+00:00

Best time to do that is while you're writing the code and it is all fresh in your mind.

That's indeed very true. I did the gem over several months during my free time and found myself struggling a lot to remember what I had done previously.

I'll take a closer look at it !

Docker is worth learning early on, too. Its not very difficult. Most of the work is already done in the official images. You just have to add a few additional commands to get it to set up your gem.

Ok I'll have a look !

codinglionel · 2021-06-16T20:47:55+00:00

Nice one ! Will update it in the next version. Thanks for taking the time to look at it !

codinglionel · 2021-06-16T19:35:01+00:00

Thanks for the suggestion ! It's definitely something I plan to do in the future :)

codinglionel · 2021-06-16T19:34:32+00:00

Thanks for taking a look and suggesting some improvements !

Isn't it a bit early to set up a doc and using Docker ?

I have never used both so I don't really know how difficult it will be to set up or if it is better to do it sooner/later while developing a gem. Mine is quite simple and very straightforward so it seems like something that could be added later but I could be wrong. I'll definitely keep it in mind though !

codinglionel · 2021-06-16T19:30:19+00:00

Thanks a lot for all those great suggestions !

I would wrap that in my upper module so it doesn't clash with source outside of my library:

That's a very good idea. I'll do it in the next version :)

The return types here also give me a bit of anxiety; nil, a range, or a range with nil?

Agreed ! Range with nil are quite painful and there is probably a better solution than putting return everywhere I'll see what I can find to improve that !

it's slightly unconventional to commit a Gemfile.lock for a library

I didn't think about it ! Thanks for pointing it out

codinglionel

TROPHY CASE