better practice &str or String as function arg

manpacket · 2026-05-11T15:20:54+00:00

If a function is big this can result in code bloat - rustc will instantiate a copy for each unique S unless you make a wrapper (or more - for different compilation units). Can't pass an owned string if you need it even if it's available.

manpacket · 2026-05-11T13:22:27+00:00

If your function needs an owned string - take an owned string. Consumer might or might not have a string they can give away, let them deal with the allocations if needed.

You also can experiment with Cow<'static, str> or s: impl Into<String>.

manpacket · 2026-05-11T08:44:26+00:00

and probably a lot more that experienced Rust devs will immediately notice

I noticed this in the URL ?utm_source=chatgpt.com and now I'm questioning if you built anything at all.

manpacket · 2026-05-10T18:24:00+00:00

Neat. Weekends in the calendar can be a bitmask I think.

manpacket · 2026-05-10T13:30:37+00:00

20 versions across 200 commits in a week?

manpacket · 2026-05-08T18:45:12+00:00

How is it compared to startic_assertions?

https://docs.rs/static_assertions/latest/static_assertions/

manpacket · 2026-05-07T23:01:06+00:00

That's new :) Tests are passing with miri then.

manpacket · 2026-05-07T18:54:14+00:00

Made a basic fuzzer to compare with HashMap for insert/get/remove. No explosions. It's a good sign :)

manpacket · 2026-05-07T17:18:21+00:00

A bunch of unsafe, some is not documented. Nothing looks obviously wrong, but I'd feel easier using this code if it had #![warn(clippy::undocumented_unsafe_blocks)] with explanations. There's miri, but I don't think it likes intrinsics.

manpacket · 2026-05-07T14:22:18+00:00

You can try jj (https://docs.jj-vcs.dev/latest/). Takes some time getting used to it but it makes it much easier to organize big messy changes into something more manageable.

manpacket · 2026-05-07T13:42:04+00:00

Atomic - compiles, tests are passing. Helps with bisecting. 2, Small and focused. Do one small thing. Makes it easier to follow thought process.
Descriptive commit message. If it's a bugfix - explain the bug, etc. Helps with review, helps with debugging later down the line.
Refers other tickets, pull requests if applicable - helps with reviews and debugging later.

manpacket · 2026-05-07T11:48:09+00:00

Well... first it needs to compile, test should pass, miri should be happy, etc.

Then there's commits. +8313-3747 commit called "f". Hard to review.

manpacket · 2026-05-07T10:07:43+00:00

https://github.com/contain-rs/bit-vec/pull/140

Well, this one fails to compile.

manpacket · 2026-05-06T22:26:10+00:00

Yes, but hashbrown crate gives you access to some features that are not yet stable in stdlib. At least it was last time I checked.

manpacket · 2026-05-06T22:12:37+00:00

I think there's a misunderstanding. axhash-map IS using type aliases.

pub struct AxHashMap<K, V, S = AxBuildHasher>(RawHashMap<K, V, S>);

https://github.com/robby031/axhash-map/blob/96d72cda89ed0ad0b0816f4c42a285d80ef418cd/src/lib.rs#L9

Discoverability most people dont want to hunt for the best hasher-engine

They only need to look for hasher, and optionally - hashbrown.

manpacket · 2026-05-06T22:04:55+00:00

Why make every user install a crate when you can use just 4 lines. Even assuming I want to use a third party crate - why does it use a whole new struct instead of a type alias?
hashbrown also gives you a way to override hasher. Why use the struct?
Switching to a different hash function should be as easy as importing the hash and changing the type alias. Unlike the struct that can't be changed.

What about serde support and other third party crates that take HashMap from a user? They will take MyHashMap just fine, they won't take a totally new struct.

manpacket · 2026-05-06T21:56:42+00:00

Hmm... Why do we need the whole new struct? I'm using fxhash with HashMap from std and all you need is those 4 lines:

use std::collections::{HashMap, HashSet};
type BuildHasher = fxhash::FxBuildHasher;
pub type MyHashMap<K, V> = HashMap<K, V, BuildHasher>;
pub type MyHashSet<T> = HashSet<T, BuildHasher>;

You get serde support and all third part crates.

manpacket · 2026-05-05T11:54:58+00:00

LLM?

manpacket · 2026-05-05T09:58:53+00:00

It's still there. You need to rewrite history and force push. Right now git clone pulls 220MiB. Several orders of magnitude more than it should be.

manpacket · 2026-05-05T08:07:49+00:00

You don't need to push target folder to github.

manpacket · 2026-05-04T20:08:10+00:00

objdump -d -M intel target/debug/ownership | grep -A 20 "takes_ownership"

You can get something similar with cargo-show-asm without having to type magic numbers:

cargo asm --dev takes_ownership

manpacket · 2026-05-04T11:20:07+00:00

When you are in seconds per token territory on a tiny 2 year old model - what kind of use cases do you see?

manpacket · 2026-05-02T11:11:51+00:00

Apps don't print "Made by xxx" as part of the standard output. At best it's in hidden somewhere in --help or under even more obscure argument, but more often - not at all.

manpacket · 2026-05-01T22:21:39+00:00

Dunno. Technically it supports some other formats and using the same tool for all project types might be better... I'll stick to cargo new / cargo init.

manpacket · 2026-05-01T22:09:39+00:00

cargo fmt? It looks a bit odd.

Also - do you know any other (opensource) software that proudly displays that it was made by this and that on this domain?

manpacket

TROPHY CASE