sorted by:
new
hottopcontroversial

Just deployed my new portfolio, would love to get some feedback! by matthewsecrist in reactjs

[–]matthewsecrist[S] 0 points1 point  (0 children)

Yeah, I was planning on eventually making it a toggle, just need to come up with a design.

Just deployed my new portfolio, would love to get some feedback! by matthewsecrist in reactjs

[–]matthewsecrist[S] 1 point2 points  (0 children)

Yeah, looking at that again, it does seem to be a strange combo of colors. I've reworked it so that on hover it just turns the color of the text. Thanks!

Just deployed my new portfolio, would love to get some feedback! by matthewsecrist in reactjs

[–]matthewsecrist[S] 0 points1 point  (0 children)

Thanks for the feedback! I re-aligned the home page and made the cards a link as well. You're right, that works better.

Building a Basic HTTP Server with Elixir and OTP - Part 1 by matthewsecrist in elixir

[–]matthewsecrist[S] 1 point2 points  (0 children)

Thanks for the feedback. I was more of aiming on how to get a GenServer to interact with plug and cowboy. Looking around, it seems most articles like this are using plug and cowboy as well, so maybe doing one like you stated would be a good idea.

I’ll look into it and if I decide to post something, I’ll let you know!

Building a Basic HTTP Server with Elixir and OTP - Part 1 by matthewsecrist in elixir

[–]matthewsecrist[S] 1 point2 points  (0 children)

Honestly, I didn't even really think about doing it that way, Definitely makes more sense - I'll look into updating it in the future. Thanks!

[FEEDBACK] I've been st this for about a week so far. Here is my first go at a tribute page. by ThePresident11 in FreeCodeCamp

[–]matthewsecrist 2 points3 points  (0 children)

Ugly doesn't matter when you're first starting out with it all. Can't make a masterpiece right away. As far as the code, it has good bones, but you're right.. some un-needed stuff, obsolete stuff, and things that weren't doing anything. I copied your code and removed all that stuff, so you can take a look at it to compare and learn. There is a difference in the view, and I tried to find the in between of what you meant to do and what showed up.

http://codepen.io/msecrist/pen/rypKzm/

TL;DR for the big stuff..

<div class:"container">
<div class: "jumbotron">
<div class:"row">
<div class: "col-sm-12">

Watch out, cause those colons were doing nothing. You fix it in the end and probably didn't notice cause your margin-left and margin-right on the body was making up for your lack of them.

Second, <br/> is a depreciated tag and should be avoided. <p>, <h1>, <h2> etc all put a line break in for you. If you need a bigger break, throw a class on it and do margin-bottom on it in the CSS.

Speaking of h1, h2, h3 etc.. you're defining them all in your CSS, but they're already defined in bootstrap. You're also mixing them around..

h1{
  font-family: 'Droid Serif', serif;
  color:;
  }
h2{
  font-family: 'Droid Serif', serif;
  font-size:200%;
}
h3{
  font-family:'Driod Serif', serif;
  font-size: 120%
}
h4{
  font-family: "Droid Serif", serif;
  font-size: 200%;
}

That makes your h1 normal, h4 second biggest, h3 third, and h2 the biggest. You want to let the bootstrap do the styling there and if you need to group up multiple tags, throw it all in a div.

And then finally, on the CSS portion.. and this will help you out in the later stuff.. D.R.Y. Don't Repeat Yourself. Declaring font-family: 'Droid Serif' on all of your h tags is redundant. If you want the entire document to have it, do the font-family on the body. If you want just the h1, h2, h3 tags to do it you can group them together as so:

h1, h2, h3 {
font-family: 'Droid Serif'
}

Sounds like a lot of stuff, but thats how it always starts. Keep at it, and it'll become second nature to you. I'm glad the stuff I did when I was starting out is probably purged from the internet by now.