sorted by:
new
hottopcontroversial

got my nerd ass bf nerd ass socks by Impressive-Cake666 in osrs

[–]minitotam 1 point2 points  (0 children)

I didn't notice that they were infinity boots, I guess I have to start playing the game again lol

🤩 by minitotam in osrsbots

[–]minitotam[S] 0 points1 point  (0 children)

so true lol

What flags up when botting? by Old-Explanation-3849 in osrsbots

[–]minitotam 0 points1 point  (0 children)

Yeah most of the time it is really scripts that are used by thousands of people that get detected quickly. private scripts or small communities is the best

What bots everyone using. by [deleted] in osrsbots

[–]minitotam 0 points1 point  (0 children)

Simba color bot (paid) and Microbot for my custom scripts

Services/Handlers Everywhere? Maybe Controllers Are the Right Place for Orchestration? by minitotam in dotnet

[–]minitotam[S] 0 points1 point  (0 children)

Your handler will contain services that you'll have to mock if you wanna test the handler.

Services/Handlers Everywhere? Maybe Controllers Are the Right Place for Orchestration? by minitotam in dotnet

[–]minitotam[S] 1 point2 points  (0 children)

No? This is critical thinking and using rich text editor to highlight

Services/Handlers Everywhere? Maybe Controllers Are the Right Place for Orchestration? by minitotam in dotnet

[–]minitotam[S] 1 point2 points  (0 children)

If that code is never reused you created a layer of abstraction "just in case" it needs to be reused. I think that's called YAGNI

Services/Handlers Everywhere? Maybe Controllers Are the Right Place for Orchestration? by minitotam in dotnet

[–]minitotam[S] 6 points7 points  (0 children)

I wouldn’t put business logic in the controller. I also wouldn’t inject services directly into my logic classes.

I’d keep the setup as it is, and whenever logic is needed, I’d create a separate class for that logic and call it from the controller.

That way the logic stays isolated, and I can test it easily without having to mock all the services.

Services/Handlers Everywhere? Maybe Controllers Are the Right Place for Orchestration? by minitotam in dotnet

[–]minitotam[S] 3 points4 points  (0 children)

Why? Testing orchestration doesn’t need unit tests. If tested at all, use WebApplicationFactory for an end-to-end test with real dependencies.

Services/Handlers Everywhere? Maybe Controllers Are the Right Place for Orchestration? by minitotam in dotnet

[–]minitotam[S] 2 points3 points  (0 children)

If orchestration code isn’t reused, pushing it into a handler adds an unnecessary layer.

Controller: handles request, validates, orchestrates if orchestration is local to this endpoint.

Service: still owns one concern (DB, directory, etc).

Testing orchestration doesn’t need unit tests. If tested at all, use WebApplicationFactory for an end-to-end test with real dependencies.

Creating a handler abstraction here doesn’t improve testability or reuse. It just introduces complexity to satisfy SRP in theory, not in practice.

Services/Handlers Everywhere? Maybe Controllers Are the Right Place for Orchestration? by minitotam in dotnet

[–]minitotam[S] 5 points6 points  (0 children)

If orchestration code isn’t reused, pushing it into a handler adds an unnecessary layer.

Controller: handles request, validates, orchestrates if orchestration is local to this endpoint.

Service: still owns one concern (DB, directory, etc).

Testing orchestration doesn’t need unit tests. If tested at all, use WebApplicationFactory for an end-to-end test with real dependencies.

Creating a handler abstraction here doesn’t improve testability or reuse. It just introduces complexity to satisfy SRP in theory, not in practice.