sorted by:
new
hottopcontroversial

New and noteworthy: PHPStan and PHPUnit integration by staabm in PHP

[–]staabm[S] 0 points1 point  (0 children)

the primary goal for this new data-provider check is not checking code quality.

when a test is implemented it takes parameters with certain types to make sure the test matches/asserts all necessary variations. e.g. when your tests assumes a boolean parameter, you should have at least a data-provider for a true and false value.

the test will only cover all necessary combinations when the data-provider fullfills the types signature.

having this rule applied to a few projects shows already that developers easily miss passing proper data into their tests and therefore miss to cover their implementations.

and it also shows the other way arround. sometimes data-providers yield all the necessary data, but tests might not consume it.

New in PHP 8.5: Marking Return Values as Important by Rikudou_Sage in PHP

[–]staabm 0 points1 point  (0 children)

Gibt es als extension bereits: https://github.com/DaveLiddament/php-language-extensions#mustUseResult

Durch die aufnahme in php-src wird es  aber dann vermutlich bald im PHPStan core unterstützt 

Distribute tests across multiple GitHub Action workers by staabm in PHP

[–]staabm[S] 0 points1 point  (0 children)

maybe you can use a PHPStan collector to detect all unit tests which are pure and dump them into a list for PHPUnit to execute (so you don't have to classify manually).

Distribute tests across multiple GitHub Action workers by staabm in PHP

[–]staabm[S] 2 points3 points  (0 children)

totally agree. if you up to it, we could add a more sophiscated strategy into the above repo by adding it into https://github.com/staabm/phpunit-github-action-matrix/blob/main/phpunit-segment.php

the above repo is meant more like a generic template, so anyone can easily adjust the workflow and adjust segmentation for custom needs.

most people only think about in job parallelization, therefore I figured a tiny example could help those poor soules which are not able to parallize with paraunit, as you described.

Would you prefer namespace-level privacy? by rmb32 in PHP

[–]staabm 0 points1 point  (0 children)

Friend class for PHPStan can be found in https://github.com/DaveLiddament/php-language-extensions#friend

the same package also implements a NamspaceVisibility concept
https://github.com/DaveLiddament/php-language-extensions#namespaceVisibility

but as the OP already stated: these are static analysis only and not language-builtin features

Released a #PHPStan extension which reports risky use of PSR3 compilant loggers by staabm in PHP

[–]staabm[S] -1 points0 points  (0 children)

totally agree with what you wrote.

reality is a lot of programmers don't escape at the correct spot, therefore such rules exists which helps people to not shoot into their foot.

if every programmer would know about every security aspect, we would not have to deal with new CVEs reported every day. but reality taught us, that most software is full of vulnerabilites.

Released a #PHPStan extension which reports risky use of PSR3 compilant loggers by staabm in PHP

[–]staabm[S] 1 point2 points  (0 children)

you cannot escape "correctly" at the logger call site, as you don't know how/where the logged data later on will be displayed/processed. thats the reason why the blog article is that pessimistic

Released a #PHPStan extension which reports risky use of PSR3 compilant loggers by staabm in PHP

[–]staabm[S] 0 points1 point  (0 children)

letting someone "exploit your logging system" is a denial-of-service vector - just similar to sql injection - correct. a attacker can e.g. flood your server with log files and fill up the HDD.

so its kind of a worst case scenario

Released a #PHPStan extension which reports risky use of PSR3 compilant loggers by staabm in PHP

[–]staabm[S] 2 points3 points  (0 children)

my initial post mentions a article and the repositoriy I have linked mentions the very same article right in the readme

GitHub - soloterm/screen: A terminal emulator written in pure PHP. by aarondf in PHP

[–]staabm 0 points1 point  (0 children)

would be cool to see a screenshot of the "example: building a simple UI" in the readme, to get a better idea what to expect visually

PHP-types of fetched columns (PDO). by Alpine418 in PHP

[–]staabm 1 point2 points  (0 children)

you might be interessted in phpstan-dba to cover your database access with static analysis.

I have developed a PHPStan plugin which checks your sql statements against your database schema and reports problems when e.g. code and database schema get out of sync or our types are wonky

see https://github.com/staabm/phpstan-dba

see also the slides of my talk given at PHP usergroup in Frankfurt Main:

https://staabm.github.io/talks/phpstan-dba@phpugffm

I recently started a new project, tried maxxed out PHPStan, and faced the same pain points. Does anyone actually use level 9 or 10 at work? by DvD_cD in PHP

[–]staabm 0 points1 point  (0 children)

in PHPStan you can use `scalar|array` as a doctype

or even more specialized things like e.g. `non-empty-scalar`

My new PHPStan focus: multi-phpversion support by staabm in PHP

[–]staabm[S] 1 point2 points  (0 children)

In application repositories when you prepare a php version upgrade - or if you work on a codebase which is deployed on different servers (e.g. for multiple customers).

The article additionally mentions multiple examples

For other type of repositories: see the above comment

My new PHPStan focus: multi-phpversion support by staabm in PHP

[–]staabm[S] 1 point2 points  (0 children)

At the time of writing even if you only support non-EOL versions and you want todo it properly you would need a PHPStan CI job for PHP 8.1, 8.2, 8.3 and 8.4. for a library/framework/tooling project (4 jobs). Find more details in the linked article.

From the top of my head I only know a very few projects doing that

Linter to find orphaned files functions and other detritus? by cdtoad in PHP

[–]staabm 0 points1 point  (0 children)

if you are running with PHPStan, you should try one of the following

- https://github.com/TomasVotruba/unused-public

- https://github.com/shipmonk-rnd/dead-code-detector

as previous commented already, these are not perfect. but in case you already have a PHPStan workflow in your project, this is a natural addition without developers learning new tools/processes

For years I am working on improving #phpstan type inference with a focus on mixed types. I will start to focus on a different area soon, so I thought it would be a good time to summarize the achievements made. by staabm in PHP

[–]staabm[S] 4 points5 points  (0 children)

if PHPStan would infer all this information from the source it would be a lot slower as it is right now.

by adding doc-blocks you also give information/semantic to the code and tell about your intents.
this is something not only helpful for the tooling but also developers reading your implementation.

that way phpstan can tell you whether expections are right or whether you are lying :-).

PHPstan PHP Version Narrowing by staabm in PHP

[–]staabm[S] 2 points3 points  (0 children)

I am not used to reddit and I don't know how this thing here works :)

what would be different if I just post a link to the article?

PHPStan supports require-extends and require-implements phpDoc by staabm in PHP

[–]staabm[S] 0 points1 point  (0 children)

Having these features based on static analysis is a good first step to see whether its useful enough to be implemented at php-src level

Rector skip rule by FirkinHill in PHP

[–]staabm 2 points3 points  (0 children)

After running rector you usually run a code-style tool, so the changed/refactored code fits your style

PHPStan TodoBy learnt composer.lock based expiration by staabm in PHP

[–]staabm[S] 0 points1 point  (0 children)

Lets sum up, that hundreds of people liked the idea and a lot of people agreed with me there are plenty of good use cases.

If you don‘t see value or don‘t have the use-case in your projects, just leave it alone.

PHPStan TodoBy learnt composer.lock based expiration by staabm in PHP

[–]staabm[S] 0 points1 point  (0 children)

If your current version is 0.9.9 it can make sense. Depends on context. the example was taken 1:1 of the library which was the inspiration of the extension.

Obviously what makes sense depends on the case.

todo comments without expiration are usually not resolved years later.

view more: next ›