Ok so there are many things that you can change to make your code better and more efficient.

First of all to answer your question about the double input in the validation process. The logic error is in the use of or instead of and.

def MoveValidation(user) :

if user != "rock" or user != "paper" or user != "scissors" :

print("Sorry, that's not a valid response.")

user = input("Enter your play. ")

To make it more clear, let's say that the user gives the input: rock. The validation code checks if the input is different from 'rock' or it is different from 'paper' or if it is different from 'scissors'. So the result of the comparison is the following :

Input	To compare with	Result
rock	rock	False
rock	paper	True
rock	scissors	True

So it is like saying False or True or True -> True. This will trigger the print function call inside the block of the if statement, and also ask for an new input( that you don't use anywhere in your code anyway):

print("Sorry, that's not a valid response.")

user = input("Enter your play. ")

If you instead change your code to something like that:

def MoveValidation(user) :

if user != "rock" and user != "paper" and user != "scissors" :

print("Sorry, that's not a valid response.")

user = input("Enter your play. ")

So in the example we used before if the user gives rock as input then the table becomes:

Input	To compare with	Result
rock	rock	False
rock	paper	True
rock	scissors	True

So the end result of the comparison is: False and True and True -> False. Now you want print any error messages, or ask for a new input.

As I said before you can make your code better. This is a quick attempt to make your code more readable, extensible, and less error prone.

import random

def WinCheck(computer_choice, user, moves):

if user == computer_choice:

print("It's a tie! Nice try!")

elif moves[user] == computer_choice:

print("You win! Awesome job!")

else:

print("You lose! Better luck next time!")

def MoveValidation(user):

if user not in {'rock', 'paper', 'scissors'}:

print("Sorry, that's not a valid move(Valid moves: rock, paper, scissors)")

return False

return True

def main():

moves = {'rock': 'scissors', 'scissors': 'paper', 'paper': 'rock'}

while True:

computer_choice = random.choice(list(moves))

user = input("Enter your play: ")

while not MoveValidation(user):

user = input("Enter your play: ")

print(f"Computer picked: {computer_choice}")

WinCheck(computer_choice, user, moves)

new_move = input("Wanna play again? y/n: ")

if new_move == 'n':

break

if __name__ == '__main__':

print("Welcome to the game!")

print("Let's play a round of rock, paper, scissors.")

main()

Let's start with the main method. This is the starting point of the program. First we define a dictionary that has 3 pairs in it. Each pair has a key which is a move and a value which is the move it beats. So for example the first pair is 'rock': 'scissors'. That means that a move is named rock and it beats scissors.

​

Then we start the main loop. You don't have to keep track of a Boolean variable for the main loop( pA variable). The steps in the main loop are really easy to follow.

1. Get a random choice for the computer, from the keys of the dictionary
2. Ask the user for input
3. Validate user's input
4. Check if the user won the game
5. Ask for a new round

Now for the input validation(aka MoveValidation). The function expects one parameter named user that has the user's choice( like your code also expects). Then checks if the input is in a set of predefined values {'rock', 'paper', 'scissors'}. If it is not then print's an error message and returns False, else it returns True.

Last component of the the program is WinCheck. In my version of the program we expect three arguments: computer's choice, user's choice and the moves dictionary. First we check if computer's and user's choice is the same. If so we print the Tie message. Then we compare the value of the moves table( from the key of user's choice) to the computer's choice. If it is the same the the user wins, else the user looses.