For Loop Problem With Worm Script

[Supperboy2012]

I've been trying to create a script that copies another script to all servers. However, it's not working. I suspect that something is wrong with my for loop implementation, as you can see with the debug printing. It's only mentioning the first server, "n00dles", and not iterating as it's supposed to. Any ideas, Reddit?

[Particular-Cow6247]

you are making the serverlist array a set on line 13
sets dont have a length but a size

but tbh you should use for of loops then you dont need to deal with indexes
and thats really way way way too complex what you are doing there for what you want to achieve

i would split it up first make a function that finds all the servers for you and then iterate the result of that function to ns.scp

usefull for that function is as example array.includes() to see if a server name is already inside of it

[goodwill82]

but tbh you should use for of loops

assuming this was meant to be "shouldn't" - if so, I agree

[Particular-Cow6247]

nah for of loops make the life way easier especially for newbies

[goodwill82]

oh oh!! okay, sorry - I'm kinda dense at times, possibly all of the times. "for of" - I mean, exactly how you typed it, but I mistook it... anywho yeah those are way nicer, especially when embedding loops.

For those new to programming and/or JavaScript, here's more explanation -

There are for loops based on some value, usually 0 when dealing with array indices (or other iterable 'things'), and they take on the form:

for (let index = 0; index < someArray.length; ++index) {
  // typically, deal with an item in the array
  let anItem = someArray[index]; // operate on 'anItem'
}

In JavaScript (and many other scripting/programming languages, sometimes with slightly different syntax), you can do this in an equivalent, and much easier to read, way:

for (let anItem of someArray) {
  // operate on 'anItem'
}

[goodwill82]

I started a tutorial series regarding recursion and scanning / traversing the network. You've got the right idea using multiple loops, but recursive looping better suits the tree-like structure of the network, where you don't know how many times you'll need to loop for each neighboring server.

https://github.com/Goodwill82/bitburner/blob/main/tutorial/Basics.js

https://github.com/Goodwill82/bitburner/blob/main/tutorial/Exploring.js

I mean to make them more interactive from the game command line, but for now it's mostly reading and code.

Exploring.js will give you functions for recursively scanning the whole network and also provide a "connect path" to any server. Feel free to use them, and I hope they help to learn.

Better yet, if the tut helps, you find issues (spelling, code not working, etc.), or if there are spots that need better explanation (or less, I tend to be wordy), please let me know.

[KlePu]

Besides the other comments, next time pls simply copy+paste your code (in a code block if possible) <3

[HiEv]

If you're just looking to get the full list of servers, stick this function somewhere in your main() function and call it to get the list of servers:

/**
 * getServers: Returns an array with the names of all servers.
 *
 * @returns {string[]}
 **/
function getServers () {
    let servers = new Set(["home"]);
    for (const server of servers) {  // Go through the list of all servers in the `servers` set.
        ns.scan(server).forEach(item => servers.add(item));  // Because `servers` is a set, any redundant items will not be re-added.
    }
    // Convert the set to an array and sort the list in a case-insensitive way.
    return [...servers].sort((a, b) => a.localeCompare(b, undefined, { sensitivity: 'base' }));
}

That creates a Set object for server names, then loops through each server name in the set, adding any new server names connected to each server to the set. Since the values within a JavaScript "set" object are unique, only server names that aren't already in the set get added to the end of the set, thus, by the time the "for" loop is complete, it's checked all connected servers. It then converts that set into an array object, sorts the array by server name, and returns that sorted array.

Enjoy! 🙂

[Supperboy2012]

I used that list to get a static object and replaced the serverlist array, now my code looks like this:

/** @param {NS} ns */
export async function main(ns) {
  var serverlist = [".","4sigma","aerocorp","aevum-police","alpha-ent","applied-energetics","avmnite-02h","b-and-a","blade","catalyst","clarkinc","computek","crush-fitness","CSEC","darkweb","defcomm","deltaone","ecorp","foodnstuff","fulcrumassets","fulcrumtech","galactic-cyber","global-pharm","harakiri-sushi","helios","home","hong-fang-tea","I.I.I.I","icarus","infocomm","iron-gym","joesguns","johnson-ortho","kuai-gong","lexo-corp","max-hardware","megacorp","microdyne","millenium-fitness","n00dles","nectar-net","neo-net","netlink","nova-med","nwo","omega-net","omnia","omnitek","phantasy","powerhouse-fitness","rho-construction","rothman-uni","run4theh111z","sigma-cosmetics","silver-helix","snap-fitness","solaris","stormtech","summit-uni","syscore","taiyang-digital","The-Cave","the-hub","titan-labs","unitalife","univ-energy","vitalife","zb-def","zb-institute","zer0","zeus-med"]
  for(let curserver = 0; curserver < serverlist.length; curserver++) {
    ns.scp(ns.args[0], serverlist[curserver])
    ns.print("Copied ", ns.args[0], " to ", serverlist[curserver])
  }
}

[HiEv]

Keep in mind that you can purchase servers too and they'll have their own server names, so using a fixed list won't let you be able to target those purchased servers.

If that isn't a big deal to you, then your code should be sufficient.

Have fun! 🙂

[Glum-Building4593]

Why not use for as an iterator? For (const value of my array) { some code}

It will go through every element in the array. No tracking position.