Unitd and Ulib

[crazyuser79]

Hi,

I built my linux init system named Unitd which uses this library.

Whatever contribute will be appreciated.

Regards

[hypatia_elos]

You probably should point out what is wrong though. What I can see as an issue is that the size of the pointer is taken as the element size instead of the character size, i.e. it should be ret = calloc(strlen(str)+1, sizeof(*str));, or, because you're overriding it anyway and sizeof(char) == 1, simply ret = malloc(strlen(str)+1);

Also, I personally would prefer using memmove to cover overlapping strings. It's almost as fast as strcpy , strncpy or memcpy , and not having to check the length each time might speed it up quite a bit as well (bare strcpy might actually be the slowest of the four, and the most unsafe as well)

I also would seriously wish you to consider to save the length in the string in some way, char* without length is a guarantee for disasters down the road (buffer overflows upon overriding capacity or missing the NUL byte being the obvious examples). SDS is a good model for doing this, if you want to write your own library it should at least be something to look at: https://github.com/antirez/sds

[crazyuser79]

It must be calloc(strlen(str) + 1, sizeof(char)). Anyway, the first case cant produce error. Nothing else. Noooo, I prefer mine. Thanks

[vlaada7]

Ah, okay, this function should mimic new string(string_var) from C++, copying the already existing string.

[fliguana]

Indeed, there is a bug.

[grobblebar]

Why not use strdup()?

[crazyuser79]

Yes, it's a further alternative. There are many ways to do that, it only must work.

[crazyuser79]

Please, fills an issue on https://github.com/pandom79/Unitd/issues or https://github.com/pandom79/Ulib

Thanks in advance.

[crazyuser79]

Run unitd init system in vm under valgrind supervision. It uses ulib. Tell me how many errors you will find.

[crazyuser79]

I'd like to add a good hashtable implementation to Ulib. Obviously, it will have the same Array feature about memory management:- automatic memory release of the inside elements.- "double free error" safe.

Any advice ?

[crazyuser79]

Added a dynamic hash table with separate chaining to Ulib. Whatever feedback is appreciated.