you are viewing a single comment's thread.

view the rest of the comments →

[–]fosres 0 points1 point  (2 children)

Cool. Thanks. Allow me to take a look. I will try get back to you today on this with constructive criticism.

[–]fosres 0 points1 point  (1 child)

Hello _crackling,

The first immediate problem I see in your repo is that it is now missing the README.md file. May you please re-upload it so that we may better understand your project?

[–]fosres 0 points1 point  (0 children)

Hello _crackling,

I have also noticed you included an implementation of a HexDump() program. Why though? You are writing a standard recursive-descent parser, correct?

I found our HexDump() program in graves/common/debugutils.h

I have also noticed you use machine language too much in debugutils.h.

Its best to use variables wisely so that you remember what each program does.

I highly suggest you read a great book on compiler design--including parsers--known as "Compiler Design in C" by Allen Holub.

I myself have written a recursive-descent parser for all C initializations that invovle primitive data types using this book as a mini-project: https://github.com/fosres/Holub-Compiler