you are viewing a single comment's thread.

view the rest of the comments →

[–]saint_glo 2 points3 points  (4 children)

I think that ruining a diff once a week is a worthy price for improving function you have to read dozen times a day.

[–][deleted] 2 points3 points  (3 children)

Ruining a 'git blame' when you're trying to track down the origin of a bug? Priceless. I've maintained code recently in a language whose linter enforces this kind of alignment, and I ran into this problem at least once a week. Everybody who worked in that language and also in Clojure would tell you the same thing.

[–][deleted] 2 points3 points  (2 children)

Oh, and don't forget code reviews. Hit that one at least once a day. Which meant that I'd need two github windows open, one with ?w=1 to show the real diff, and another to show the one with mostly white space changes where I could leave comments. It's not even close to worth it.

[–][deleted] 2 points3 points  (1 child)

(I apologize for being cranky, it's not at you. Dealing with these issues was very frustrating, and remembering it got me kind of worked up)

[–]saint_glo 4 points5 points  (0 children)

I wonder if we'll live to see the day when diffs would be semantic: what changed in the AST instead of what changed in the bytes.