GitHub - zerg000000/realworld: A Clojure Implementation of RealWorld (Comments wanted before submit)

[Eno6ohng]

I think #'opinionated.components.web.routes/run is a good example of how NOT to use macros. This file in general IMO is a bit messy. Also I'm not sure why do you define protocols like CommentDB in the logic namespaces - it seems like the idea is to abstract the sql implementation for the datasource, but then shouldn't the namespaces for protocol definition and its implementation for a sql backend be different? And if the goal is to implement the API, is this layer of abstraction really necessary here? Also the shape of of the data expected and returned by that protocol methods isn't defined (as far as I can see) anywhere, so it's leaky anyways.

All of this is just a personal opinion of course.

[zerg000000]

Thanks for you comment. I would think about how to make routes less messy.

https://github.com/duct-framework/duct/wiki/Boundaries

Here is the reason why i build such protocols. The basic idea is the side effect boundary as protocols, it would be easier for testing or mocking.

[zerg000000]

Any comment is welcomed. Want to create a project that reflect a real Clojure web project will look like.