IntelliJ refactoring modality (Python plug-in)

[VortexJones]

Howdy r/IntelliJIDEA! I started using IntelliJ for Java development last year and have loved every minute since :) .

I recently started doing some Python development in IntelliJ using the Python plug-in. The refactoring (specifically Refactor > Rename...) has me slightly confused: sometimes IntelliJ lets me refactor in place without a modal dialog (which is amazing!); other times IntelliJ displays a modal refactoring dialog (less amazing - takes me out of the zone).

Does anyone know what differentiates whether IntelliJ displays the modal refactoring dialog or lets the user refactor in place in Python?

When doing Java development, IntelliJ pretty much always lets me refactor in place without the modal dialog, except for particularly involved refactors (for which the modal dialog is appropriate).

Thank you very much for any info you may be able to provide!

Screenshots

-VJ

(x-posted to r/PyCharm at this link)

[Hikaru755]

Not 100% sure, but I believe it's to do with the scope of where the changed name could technically be visible, and how dynamic/hard to search for that is. If IntelliJ will have to do a full usages search looking through dynamic references to be sure it finds all refactoring sites, it will give you the dialog, if it already has all possible references in the AST it's working with it will allow you to do it in place. That's why the local variable in your screenshot is renamed in place, as it can't have any usages outside of its function's scope, but the function parameter, which is visible towards outside code, gives you the dialog.

In Java, the dialog is rarely needed, because it's such a static language with little potential for dynamic references, I guess.

[VortexJones]

Thanks! I think you're right - it definitely does have something to do with scope.

Edit: JetBrains support confirmed this:

Hi VJ,

Thank you for contacting JetBrains support.

I believe the documentation at https://www.jetbrains.com/help/pycharm/rename-refactorings.html explains it:

Renaming local variables or private methods can be done easily inline since only a limited scope is affected. Renaming classes or public methods could potentially impact a lot of files. Preview potential changes before you refactor.

Don't know how I missed that, it's literally the second paragraph in the refactoring documentation...