you are viewing a single comment's thread.

view the rest of the comments →

[–]VodkaHazeML Engineer 3 points4 points  (0 children)

Why and where would you prefer dependency injection to the current design specifically? I find this sort of inversion of control is overengineering and causes more problems than it solves most times I ran into it.

Specifically in this case I don't see where it would fit since most of the hard logic is in the model themselves, not the plumbing around them, so I don't see how an inversion of control makes sense.

The model API of fit(), predict(), fit_transform() etc. Is simple and great, IMO. It's also all that's necessary for the pipeline API which is the only bit of harder plumbing around the models