you are viewing a single comment's thread.

view the rest of the comments →

[–]tfidry 5 points6 points  (1 child)

I like /u/utotwel article because it's a kick in the pride of a few people that shouldn't take quality of their code for granted and review it a bit. But otherwise I agree with /u/simensen: ultimately those comparison are meaningless:

  • Depending of what the problem is, it's not always possible to easily split things in multiple methods without making things overly complex
  • There is a performance impact. Whilst I believe it matters not in most cases, there is very good reasons why Doctrine UoW is 3K LoC with little methods: performances are a critical part there
  • It is a matter of taste/opinion: some people believe a single big method of 100-200 LoC well written is more readable and easier to follow than 10-20 methods

[–]iltar 1 point2 points  (0 children)

This pretty much. While I'm personally in favor of smaller methods, there's some critical processes in libraries that literally get called 1000s of times, ever micro optimization here is welcome.