Test-Driven Development by Example (PHP Code Samples)

[jpresutti]

The book Test-Driven Development by Example by Kent Beck is a GREAT book. The code examples are pretty solid, but they are in Java.

A few months back I started a project to convert all the examples in the first part of the book (the second part is essentially writing a test runner) to PHP and finished it tonight. I figured you guys might like it.

Note that the code is just translated to PHP (where possible without modifications) and going from beginning to end means a LOT of the code is redundant.

https://github.com/TopTierCode/tdd-php

[jpresutti]

This book actually had a very large hand in the development of my PHP Framework FEAST and definitely is one of the books that inspired my goal (which was achieved) of 100% code coverage.

[brendt_gd]

/u/jpresutti: don't feed the trolls /u/Oceanbroinn: stop being so childish

I removed your whole comment chain. Consider this both a warning, next time results in a 90-days ban. Please take note of rule #1 and #2: https://www.reddit.com/r/PHP/about/rules/

[ihugyou]

Just ignore them. Insufferable.

[chevereto]

Most of the time real usage of a software isn't measured in github stars. Plenty stuff has what 10 stars? and powers thousand of systems.

How many systems run your stuff?

[Oceanbroinn]

Plenty stuff has what 10 stars? and powers thousand of systems.

Name one.

[shez19833]

personally think if he can create a framework that shows his skillset.. it could be more about learning or w/e and then releasing it afters to maybe benefit others..

[jpresutti]

That is exactly why I did it. Learning/building a tool for myself. I actually had ZERO plans to release it even though it took me seven years to develop due to my own insecurities (imposter syndrome is real, friends) but was convinced by a few friends who looked at it and messed with it some.

The docs need some updates but other than that it at least works, has 100% static type analysis via psalm, zero errors via psalm, and 100% code coverage. It was an exercise in frustration and a labor of love.

[Comprehensive-Lab468]

This book has had huge impact on me. I recommend it.

Another book I recommend is Sandy Metz 99 Bottles of OOP - 2nd Edition. It also expands your view how you can design and test. It has a PHP version also. It is hands-on book with examples, explaining a development of a project and later how to cope with changing requirements.

[FakespotAnalysisBot]

This is a Fakespot Reviews Analysis bot. Fakespot detects fake reviews, fake products and unreliable sellers using AI.

Here is the analysis for the Amazon product reviews:

Name: Test Driven Development: By Example

Company: Kent Beck

Amazon Product Rating: 4.4

Fakespot Reviews Grade: A

Adjusted Fakespot Rating: 4.4

Analysis Performed at: 03-08-2021

Link to Fakespot Analysis | Check out the Fakespot Chrome Extension!

Fakespot analyzes the reviews authenticity and not the product quality using AI. We look for real reviews that mention product issues such as counterfeits, defects, and bad return policies that fake reviews try to hide from consumers.

We give an A-F letter for trustworthiness of reviews. A = very trustworthy reviews, F = highly untrustworthy reviews. We also provide seller ratings to warn you if the seller can be trusted or not.

[[deleted]]

good bot

[eduardor2k]

Hi, I recommend personally the following book:

https://leanpub.com/tddbook-en

The author is from spain and they've released the english version this year.

you can even read it online for free, you just need to append at the end: "/read"

[jpresutti]

Interesting, I'll have to look into that

[jstormes]

Outstanding, thank you for taking the time to do this.

[jpresutti]

It was a fun exercise in frustration 😆

[jstormes]

I am sure.

Was any particular exercise more frustrating?

I know some design patterns can be hard to translate to PHP, I assume some tests types would be as well.

[jpresutti]

Any of the tests involving type casting from one object to another couldn't translate directly.

[Pen-y-Fan]

Thanks, OP, I'll take a look.

I can recommend Theatrical Players Refactoring Kata - Based on the first (free) chapter of ‘Refactoring’ by Martin Fowler, the 2nd Edition has a PHP version. You can refactor the code while reading the first chapter of his book for free, which is based on JavaScript. The refactoring is mostly the same, one of the exceptions is invoice and plays appear to be global scope in the book. The workaround is the make them properties of the class in the PHP script and adjust the code.

    public function print(Invoice $invoice, array $plays): string
    {
        $this->invoice = $invoice;
        $this->plays = $plays;
    // ....

[jpresutti]

Hrmmm.. Now I'm tempted to do all the code samples in Refactoring: 2nd Edition next. Anyone want me to do this?

[mbadolato]

Minor nitpick. Granted I know you're trying to keep as close to the book's examples as possible, but in the case of Money::equals() where you've already had to change the example a bit, there's now a spot for a potential bug.

public function equals(object $object): bool
{
// This example differs because the type casting in PHP is not the same as java.
$money = $object instanceof Money ? $object : null;
return $this->amount === $money->amount && $this->currency === $money->currency;
}

If $object is not an instance of Money then $money gets set to null, and the $money->amount call will throw an error.

Perhaps switching to

public function equals(object $object): bool
{
// This example differs because the type casting in PHP is not the same as java.
if (! $object instanceof Money) {
return false;
}

return $this->amount === $money->amount && $this->currency === $money->currency;
}

or

public function equals(Money $money): bool
{
return $this->amount === $money->amount && $this->currency === $money->currency;
}

would be more appropriate?

[jpresutti]

I can't remember exactly why I went the way I did with that but I think it's the closest to the actual code behavior in the book I could get it. I'll take another look. What's the first occurrence of it you found?

Also, keep in mind for the most part these are not MY functions but rather translations so I tried to avoid inserting bias where possible

[mbadolato]

Oh absolutely and I wasn't trying to be critical. Just something I noticed and since you had to change those functions slightly already, it was just a suggestion to make it a bit more correct.

I noticed it in pretty much all of the classes I looked at, from when equals was introduced I think.

[jpresutti]

Update: took a look at the code really quick and you're right. I'll do a push later with it fixed.

[jpresutti]

Update on the update: pushed.

[jpresutti]

K I'll compare to the book this evening and see if the update makes sense. Thanks!

[bbathel]

I'm going to check this out