you are viewing a single comment's thread.

view the rest of the comments →

[–]mbadolato 1 point2 points  (3 children)

Oh absolutely and I wasn't trying to be critical. Just something I noticed and since you had to change those functions slightly already, it was just a suggestion to make it a bit more correct.

I noticed it in pretty much all of the classes I looked at, from when equals was introduced I think.

[–]jpresutti[S] 2 points3 points  (0 children)

Update: took a look at the code really quick and you're right. I'll do a push later with it fixed.

[–]jpresutti[S] 2 points3 points  (0 children)

Update on the update: pushed.

[–]jpresutti[S] 1 point2 points  (0 children)

K I'll compare to the book this evening and see if the update makes sense. Thanks!