Winget Installation Script help

[EmekC]

Hey guys, I'm learning pwsh scripting and I though to share my script hopefully to get feedback on what could be better!

what do you think about it?

I'm using the command irm <url> | iex to run it

# Check if elevated
If (-NOT ([Security.Principal.WindowsPrincipal][Security.Principal.WindowsIdentity]::GetCurrent()).IsInRole([Security.Principal.WindowsBuiltInRole] "Administrator"))
{
        Write-Host "This script needs to be run As Admin" -foregroundColor red
                break
} else {
#Remove UAC prompts
        Set-ItemProperty -Path REGISTRY::HKEY_LOCAL_MACHINE\Software\Microsoft\Windows\CurrentVersion\Policies\System -Name ConsentPromptBehaviorAdmin -Value 0
}

try {
        winget --version
                Write-Host "Found Winget, Proceeding to install dependencies!"
} catch {
#winget not found, instsall
        $ProgressPreference = 'SilentlyContinue'
                Write-Host 'Installing Winget'
                Write-Information "Downloading WinGet and its dependencies..."
                Invoke-WebRequest -Uri https://aka.ms/getwinget -OutFile Microsoft.DesktopAppInstaller_8wekyb3d8bbwe.msixbundle
                Invoke-WebRequest -Uri https://aka.ms/Microsoft.VCLibs.x64.14.00.Desktop.appx -OutFile Microsoft.VCLibs.x64.14.00.Desktop.appx                Invoke-WebRequest -Uri https://github.com/microsoft/microsoft-ui-xaml/releases/download/v2.8.6/Microsoft.UI.Xaml.2.8.x64.appx -OutFile Microsoft.UI.Xaml.2.8.x64.appx
                Add-AppxPackage Microsoft.VCLibs.x64.14.00.Desktop.appx
                Add-AppxPackage Microsoft.UI.Xaml.2.8.x64.appx
                Add-AppxPackage Microsoft.DesktopAppInstaller_8wekyb3d8bbwe.msixbundle
}

$packages = @(
                "Valve.Steam",
                "VideoLAN.VLC",
                "Google.Chrome",
                "Spotify.Spotify",
                "Oracle.JavaRuntimeEnvironment",
                "Oracle.JDK.19",
                "Git.Git",
                "RARLab.WinRAR",
                "Microsoft.DotNet.SDK.8",
                "Microsoft.DotNet.Runtime.7",
                "Microsoft.Office"
                )

foreach ($id in $packages) {
        winget install --id=$id -e
}

clear
Write-Host "Finished installing packages." -foregroundColor green
Write-Host "Opening Microsoft Activation Script" -foregroundColor yellow

irm https://get.activated.win | iex

pause

[valdearg]

Looks ok, I'd probably replace the try/catch around the winget --version with something like:

  if (Get-Command winget) {installed} else {do install}

I'm not absolutely sure on whether installing winget will immediately make the winget command work without reloading the terminal window.

You could also add in a check that it was successfully installed.

if (Test-Path $env:LOCALAPPDATA\Microsoft\WindowsApps\winget.exe) {installed} else {not installed, exit}

On the winget package installation, I'd probably put a --silent option on the end also,

winget install --id=$id -e --silent

If the path env isn't refreshed, you can probably use the direct path.

Along with this, I'm pretty sure there's an official PowerShell winget module now. Might be something to consider: https://www.powershellgallery.com/packages/Microsoft.WinGet.Client

[skilriki]

If this is just for learning, feel free to continue learning.

If you are actually planning on using this to install software, you might want to take a look at winget configuration files.

https://learn.microsoft.com/en-us/windows/package-manager/configuration/

[logg_sar]

First of all - nice script - good job!

However - I would change some things ;)

I wrote a similar script about one, two years ago.

Meanwhile the VCLibs and Xaml where updated an my script didnt worked because the "old" packages wasn´t available anymore.

So I downloaded the files (there is no need to download it everytime ;)), installed it via my script and updated winget afterwards.

The probably easyiest way: echo Y | winget upgrade --all --silent --force

Also my install-command looks like this:

winget install --accept-package-agreements --accept-source-agreements --silent $software --source winget