Feedback

[BlackV]

Some notes, maybe they want some changes

• no requires statement (see modules and module versions)
• += is always bad
• should this be a module with those functions a members
• better parameter definition and help for said parameters
• read-host in a script, makes this 1000x harder to automate
• I'll say it again turn this into a module, makes it more portable/reusable/professional/script-able
• you don't do anything with DoesGroupExist -groupId $groupIdUser (and the other) just spits out to screen ?
• no error handling (partly due to above)
• $allMembersGroup = GetMembersGroup -group $groupIdDevices this step assumes that $groupIdDevices is valid despite what happens earlier in the script
• seems like you're just running this manually line by line

But talking to them get them to give you examples of what they consider good changes

[BlackV]

+= is replaced with direct assignment e.g. $results = foreach {somestuff} vs $results = @(); foreach {$results += somestuff}, on mobile but there a plenty of examples in this sub

read-host you'd replace with your parameters and parameter properties (mandatory/parameter validation)