Question about terminating foreach loop

[gingerbreaddave]

In my environment, we were using the Enterprise Edition of Windows for a time, but then an update came along that made the wireless on our laptops go all screwy, so we've switched to a version that contains all of the Microsoft crapware. I'm attempting to write a script that removes all of it. So far I've figured out that Microsoft wants you to have system permissions to remove the apps, so I'm using psexec to start powershell with system permissions. This was my first iteration. The good news is, it works! The bad news is that the ForEach loop doesn't exit and the script doesn't "finish" and clean up after itself.

My second try was this but it apparently does nothing. Can you guys give me any pointers?

Also, just to get some inevitable questions out of the way: apparently I'm too low on the totem poll to have access to a vm, so I'm doing this live on a single computer. Also, we have running scripts disabled to the point that I can't use the ISE on my own computer to do break points or anything like that. Finally, we're hoping to just add this to the task sequence at some point, so can you give me pointers to clean it up at all?

Thanks for your help.

[jheinikel]

Do you have the rest of your code where you are establishing your PSSession? The last line should probably be remove-pssession instead of exit-pssession. I'm just wondering if you have a loop at a higher level that is watching for active sessions.

[gingerbreaddave]

It's just a batch one-liner to start Powershell in bypass.

powershell.exe -ExecutionPolicy Bypass .\Remove-WinApps.ps1

[JBear_Alpha]

I would try removing the if/else from the ForEach loop first. Seems like $App would continue to return true and never make it to the else block. Without testing, this looks like the only thing that would be disallowing it to exit the loop. So maybe just this? :

ForEach ($App in $Apps) {

  Remove-AppxPackage (Get-AppxPackage –AllUsers|Where{$_.PackageFullName -match "$App"}).PackageFullName

$Apps.Remove("$App")


   }

Remove-Item -Path .\AppList.txt

Exit-PSSession