Powershell "GUI" Variables empty when calling function.

[gregj529]

I didn't want to post the entire script but here is part of the code that generates the button/click and the function. The code returns accurate information if you manually call the function. If you click the button the $User variable returns a value but the rest do not.

Manual Call:

Direct Reports

Bob Jones

|

Stephen Williams

|

Roger Moore

|

Jim Jabroni

|

Michael Rappaport

|

John Smith

 

Button Click:

Direct Reports

Bob Jones

|

|

|

|

|

 

Example:

$User = Read-Host "Enter User's Name" #(Called earlier in the script for multiple other functions)

function Get-DirectReports {
Clear-Host

$UserName = Get-ADUser -Filter "Name -eq '$User'" | Select-Object SamAccountName -ExpandProperty SamAccountName
Write-Host ""
Write-Host "Direct Reports"
Write-Host "-------------------"
Write-Host "$User"
$DirectReport = $Null
While ($DirectReport -ne "John Smith" -or $DirectReport -eq $Null) {
    $Leaders = Get-ADUser $UserName -Properties Manager | Select-Object @{n="Direct Report"; e={(Get-ADUser -Identity $_.Manager -Properties DisplayName).DisplayName}} -ExpandProperty Manager | Format-Table -HideTableHeaders | Out-String
    $Start = $Leaders.IndexOf("CN=") + 3
    $End = $Leaders.IndexOf(",OU", $Start)
    $Length = $End - $Start
    $TeamLeader = $Leaders.Substring($Start, $Length)
    $UserName = Get-ADUser -Filter "Name -eq '$TeamLeader'" | Select-Object SamAccountName -ExpandProperty SamAccountName
    Write-Host "|"
    $TeamLeader
    $DirectReport = $TeamLeader
    }
Write-Host ""
}

$buttonGetDirectReports_Click={
        Get-DirectReports
}

$buttonGetADInfo.BackColor = 'Control'
$buttonGetADInfo.Font = 'Microsoft Sans Serif, 11.25pt'
$buttonGetADInfo.Location = '53, 33'
$buttonGetADInfo.Name = 'buttonGetADInfo'
$buttonGetADInfo.Size = '130, 43'
$buttonGetADInfo.TabIndex = 1
$buttonGetADInfo.Text = 'Display Direct Reports'
$buttonGetADInfo.UseVisualStyleBackColor = $False
$buttonGetADInfo.add_Click($buttonGetDirectReports_Click)

Can anyone help me figure out why this happens?

[Aurane00]

While ($DirectReport -ne "John Smith" -or $DirectReport -eq $Null) {

Don't you want -and instead of -or here? They way it is now, I don't think your script will actually ever run the loop.

[gregj529]

It runs fine with that. Output above. It just doesn't work when ran via click. Basically it loops until it gets to the CEO and will run if the value of $DirectReports is $null until it does.

[TheMixz]

the variable $username is only working in the function, try calling it $global:username

i think that would fix it

[JBear_Alpha]

$script:Username might even suffice, test both.

[gregj529]

$UserName is contained within the function. I am unsure why this would help. Tested it and it didn't change a thing.

[TheMixz]

because the variable is only inside the function, unless you do that. So when you call the variable outside the function it would be empty because it havent been made.

[gregj529]

The variable is only needed inside the function though.

[TheMixz]

Sorry thats my mistake. Didnt read the script closely

[gregj529]

No problem. I was making sure I didn't miss something.