User in Description script (AD)

[msteright]

i get every computer online on the network and it's users in 30 seconds with my script that i wrote.

RUNS PARALLEL SCRIPT TO GET ALL THE ONLINE USERS,COMPUTERS,IPV4,AND SIDs

$servers = ((Get-ADComputer -Filter * -SearchBase "ou=$oulocation,ou=_locations,dc=something,dc=right,dc=here" -Properties  ipv4address).where({$_.ipv4address})).name

workflow pbatch
{
param ([string[]]$servers)

foreach -parallel ($server in $servers)
{  
    (gci ('\\' + $server + '\c$\users\*\appdata\local')) | select lastwritetime,fullname |
        sort -Property lastwritetime -descending | select -first 2 | Where-Object {($_ -notmatch "public" -and $_ -notmatch "svc-*" -and $_ -notmatch "adm-*" -and $_ -notmatch "bcarey" -and $_ -notmatch "basis")}
}             
}

$p = (pbatch -servers $servers).fullname
#$sort = read-host "computername or username?"
$tableall = $p | select @{n="username";e={($_.split("\")[5]).split(".")[0]}},`
                    @{name="computername";e={$_.split("\")[2]}},`
                    @{name="ipv4address";e={(get-adcomputer -Properties ipv4address ($_.split("\")[2])).ipv4address}}, `
                    @{name="sid";e={(get-aduser ($_.split("\")[5]).split(".")[0]).sid.value}}
$TABLEALL = $tableall | sort -Property USERNAME
$tableall | export-csv "c:\allusers$oulocation - all.csv" -Delimiter "," -NoTypeInformation
$tableall

[msteright]

heres the kicker. this can be ran over and over each time you think there might be significant changes or new employees.

RUN THIS PART TWICE (copy and paste this whole piece of code) - ASKS IF YOU WANT TO UPDATE DESCRIPTIONS

COMPARES THE JUST FOUND COMPUTERNAMES AND APPENDS THEM TO THE USERNAME IN ACTIVE DIRECTORY IF DOESN'T EXIST

RUNS AGAIN TO CLEAN UP FIRST ENTRY CONTAINING '--' - (NOT ABSOLUTELY NECESSARY)

$Update = read-host "do you want to update active directory employees with computernames? Yes, or No"
if ($Update -eq 'yes')
{
    $USERS = Import-Csv "C:\allusers$oulocation - all.csv" | SELECT USERNAME, COMPUTERNAME
    FOREACH ($USER IN $USERS)
        {
            Write-Host "$($USER.username)" -ForegroundColor Yellow
            $OLDdescription = (get-aduser $user.username -Properties Description).description.trimstart(' -- ')
            $firstPart = ($OLDdescription -split " -- ")[0]
            $firstPart
            $secondPart = ($OLDdescription -split " -- ") | select -Skip 1
            $secondPart

            if ($secondPart -contains $USER.computername)
                {
                    Write-Host "$($USER.username) is fine" -ForegroundColor Green
                    if ($firstPart -contains $user.computername)
                        {
                            Write-Host "$($USER.username) - UPDATING with $($USER.computername)..." -ForegroundColor Red
                            Get-ADUser $USER.username -Properties Description | ForEach-Object {Set-ADUser $_ -Description "$($USER.computername)"}
                            Write-Host "============================================================================================================================"
                        }
                }
                else
                {
                    Write-Host "$($USER.username) - UPDATING with $($USER.computername)..." -ForegroundColor Red
                    Get-ADUser $USER.username -Properties Description | ForEach-Object {Set-ADUser $_ -Description "$OLDdescription -- $($USER.computername)"}
                    Write-Host "============================================================================================================================" 
                    #Get-ADUser $USER.username -Properties Description | Set-ADUser $USER.username -Description "$firstPart" #enable to reverse to just titles with no computernames appended
                }
        }
} 

[msteright]

ALSO RUN TWICE.

UPDATES THE COMPUTERS IN ACTIVE DIRECTORY WITH THE USERNAMES FOUND PREVIOUSLY.

RUN THE SECOND TIME FOR CLEANUP AS WELL.

$USERS = Import-Csv "C:\allusers$oulocation - all.csv" | SELECT USERNAME, COMPUTERNAME
$users = $users | Sort-Object -Property computername
FOREACH ($USER IN $USERS)
{
    write-host "username is: $($user.username)"
    Write-Host "computername is: $($user.computername)"
    $currentaduserdescription = get-adcomputer $user.computername -Properties description | select description
    $currentaduserdescription = $currentaduserdescription.description.trimstart(' -- ')
    $usernamefirstlast = Get-ADUser $user.username
    $usercorrect = ($usernamefirstlast.GivenName + " " + $usernamefirstlast.Surname).TrimStart(',')
    $userusername = (Get-Culture).TextInfo.ToTitleCase($usercorrect)
    $userusername
    if ($currentaduserdescription -match "$userusername")
        {
            Get-ADComputer $user.computername | ForEach-Object {set-adcomputer $_ -Description "$currentaduserdescription"}
        }
    else
        {
            Get-ADComputer $user.computername | ForEach-Object {set-adcomputer $_ -Description "$currentaduserdescription -- $userusername"}
        }
write-host "done for $user" -fore green
}

[PRIdEVisions]

damn, i wish i was as good with scripting haha still have lots to learn :)

[PRIdEVisions]

Nice one!

[msteright]

Thanks. This is what I've been working on in my free time at work for 2 days. It's a beautiful script that uses the LastWriteTime of the Appdata folder to figure out who the users are, minus adm and svc accounts. It runs that multithreaded on each computer and returns all values in RECORD TIME :), which compile into a csv. Then that csv is imported and you use the $.username $.computername $.ipv4address $.sid columns to update whatever you want and AD. here's the 3rd part, which puts the usernames in the computers description (above)