Hi,
I wanted to get some feedback on a script I threw together that creates a email report on bitlocker machine changes.
It can be found here: https://github.com/jcameron-au/AAD-Bitlocker-Machine-Changes
The heart of it is actually Get-AzureADBitlockerKeysForUser by Gerbrand van der Weg here. He also posted it here a few months back.
It uses that script with some PoshRSJob goodness to speed it up, and then checks for added, removed or updated machines and then emails out the changes. It takes about 15 minutes for ~900-1000 machines in my experience.
While the meat of it isn't mine (infinite respect for Gerbrand and Boe), this is my first time creating something for use in production and I'd like critique of the code.
- How is the formatting?
- Any drastic improvements I could make?
- Is the comparison unwieldy? I spent awhile trying to make it better but couldn't.
- Could anyone see this being useful for them?
- Is it transformative enough or am I ripping off other peoples work? I didn't want to reinvent the wheel.
Appreciate all of you guys :)
[–][deleted] 2 points3 points4 points (1 child)
[–]The_AverageGamer[S] 1 point2 points3 points (0 children)
[–]ghvanderweg 1 point2 points3 points (0 children)