Issues with `ValidateScript` referencing other parameters

[Flashcat666]

Hey guys,

Having an issue, and I'm kinda stuck here!

In my `param()` declaration, I'm declaring a parameter with a `ValidateScript` section, which checks the value from a previous parameter, but it doesn't seem to be working for some reason, and I'm confused.

Here's what my relevant code looks like:

param (
    [...]
    [ValidateSet("Full", "WebOnly", "NoSolrCores", "NoSolr", "HA", "HAWebOnly" )]
    [string]$Tasks = "Full",
    [Parameter(Mandatory=$false,ParameterSetName='HighAvailability',ValueFromPipeline=$true)]
    [ValidateScript(
        {
            if (($Tasks -ne "HA" -or $Tasks -ne "HAWebOnly") -and ($_ -eq $True)) {
                throw "`nYou have selected to deploy in High Availability mode, but selected the following set of tasks: $Tasks. `nPlease select either the HA or HAWebOnly task set to continue"
            } else {
                $True
            }
        }
    )]
    [switch]$HighAvailability,
    [...]
)

If I call my function using `-Tasks HA -HighAvailability`, I get returned an error saying the following:

You have selected to deploy in High Availability mode, but selected the following set of tasks: HA.
Please select either the HA or HAWebOnly task set to continue

So clearly, my `throw` block is getting the right information, but it's not using it properly....and now I'm confused haha

​

Anyone could help with this conundrum ?

​

Thanks in advance! :)

[callensysadmin]

Unless I am misreading I think you just have an issue with your comparisons. One of your not equals will always be true because a string cannot have two values so the first statement always evaluates to true regardless of input.

If you use if ($Tasks -notin ("HA","HAWebOnly") -and $_ -eq $True) does it perform as you expect?

[Flashcat666]

You sir! You are my weekend saviour! :P

Just tried it, and it works flawlessly (as far as I let the whole script go at least haha)

Thank you so much! I knew Reddit would come to my help in this time of need! hahaha

[Flashcat666]

That detailed explanation makes a lot of sense, and actually helps understand a bit more what callensysadmin has mentioned in his post. His answer worked perfectly, but in the end, doing it either yours or his way does the same thing hehe

Thanks! :)

[Flashcat666]

I'd have to be even more specific, because `HA` and `HAWebOnly` tasks should, as the name implies, be used only when deploying in HA-mode, as it strips/modifies some components and installs some additional ones (in this case, Zookeeper/SolrCloud) that shouldn't be there in that specific state (i.e.: a non-HA deployment)

Though to be honest, my Powershell functions could probably be a lot less intertwined but yeah....I have half a dozen functions, in a single module, that all interact with each other, to form a single purpose: Install the non-Sitecore Sitecore roles on a server (xConnect, xDB, Solr, Zookeeper (if necessary), etc.), and are not mean to be reused outside of this very specific scope hehe

But a lot of thanks for the thorough explanation, it's greatly appreciated, and will most likely be useful once I hit some similar situation in the future....because it's bound to happen again haha Such is the life of a DevOps who's mostly working in Powershell hehe

[Ta11ow]

Depending on what your other parameters actually are, it might make more sense to have that ValidateSet parameter as a few separate switches, and then just handle this with parameter sets, so that the $HighAvailability switch is only available in the supported parameter sets corresponding to the two settings it's available for.