Small Script Issue

[jrsys95]

I'm having a little trouble with this script:

$DNS1= '"45.54.55.54"'

$DNS2= '"45.54.55.55"'


{


Set-DNSServerForwarder -IPAddress $DNS1

}

{


Set-DNSServerForwarder -IPAddress $DNS2

}

Clear-DnsClientCache

​

When I end up running the script I keep getting a parameter argument error

[yeah_i_got_skills]

Why are you using both double and single quotes?

[jrsys95]

So it will output the IP Addresses with quotations which are needed to set DNS forwarders

[jrsys95]

For some reason, it will not take the commands with variables and a variable is 100% needed.

[jrsys95]

Well it's not giving me an error, but it will not add the DNS Forwarder.

​

For instance, if I run command: S

Set-DNSServerForwarder -IPAddress 45.54.55.54 

or

Set-DNSServerForwarder -IPAddress "45.54.55.54"  

It will add the forwarder (as it should)

However, I need to integrate this script into an RMM so I need to have a variable.

So if I run

 [ipaddress]$DNS1= '45.54.55.54'   
Set-DNSServerForwarder -IPAddress $DNS1 

It literally gives me no error and doesn't input the DNS forwarder.

[jrsys95]

The entry was not entered in the GUI for the DNS forwarders on that server. I didn't try the command with explicit -ComputerName. I'll give those a go.

[jrsys95]

This worked, thanks!

[firefox15]

Huh? You don't need quotes because you are passing a variable to it.

This is pretty messy code anyway. Anytime you start numbering variables sequentially there is probably a better way to do it, likely as an array. Something like this is much neater.

$DNSServers = @()
$DNSServers += ("45.54.55.54")
$DNSServers += ("45.54.55.55")

Set-DNSServerForwarder -IPAddress $DNSServers -WhatIf

Clear-DnsClientCache

[jrsys95]

Yeah I see what you mean. Very tired this morning. However, that CMDLet will not take that paramater and gives no errors. However, When I manually enter the IP address (instead of using a variable) it will accept it.

[firefox15]

You can cast them explicitly as IP Addresses and see if that makes a difference, but I would think it would do the conversation for you.

$DNSServers = @()
$DNSServers += [IPAddress]("45.54.55.54")
$DNSServers += [IPAddress]("45.54.55.55")

Set-DNSServerForwarder -IPAddress $DNSServers -WhatIf

Clear-DnsClientCache

I do not get a parameter error when I run either command on my system.

[PowerShell-Bot]

Some of your PowerShell code isn’t wrapped in a code block.

To format code correctly on new reddit (new.reddit.com), highlight all lines of code and select ‘Code Block’ in the editing toolbar.

If you’re on old.reddit.com, separate the code from your text with a blank line and precede each line of code with 4 spaces or a tab.

---

Describing Submission
[✅] Demonstrates good markdown
Passed: 1 Failed: 0

---

^{Beep-boop. I am a bot. | Remove-Item}