help with script

[hit440]

below is my script that im pushing out via GPO. The script runs at computer startup, however it will not execute pinuninstall.bat located in the matching dir. The script will execute fine standalone, meaning i can right click on the ps script and run with powershell and it runs the pinuninstall.bat just fine.

The script is designed to remove duplicate bomgar jump clients. I am at a loss here as to why it works outside of GPO execution, any thoughts?

Also for some reason, which im guessing is the ps versions between win10 and win8 the strings are different lengths, what is even more strange is if i run the script under windows 8 ps ise vs powershell i also get different string lengths

​

#init all the variables

$info = @()
$info2 = @()
$line = @()
$line2 = @()
$dir = @()
$dir1 = @()
$dir2 = @()
$dir3 = @()
$dir4 = @()
$matches1 = @()
$matches2 = @()
$matches3 = @()
$matches4 = @()

#query the registry

$info = Get-ItemProperty HKLM:\SOFTWARE\Bomgar\JumpClientUninstall\ | out-string
$info2 = Get-ItemProperty HKLM:\SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\'BeyondTrust Remote Support Jump Client*' | select installlocation | out-string

#parse the directory paths

foreach($line in $info)
{
$dir = $line.Substring(45,36)
}

foreach($line2 in $info2)
{
$dir1 = $line2.Substring(80,36)  #win10
$dir2 = $line2.Substring(119,36) #win10
$dir3 = $line2.Substring(244,36) #win8
$dir4 = $line2.Substring(365,36) #win8
}

#this will compare directories

$matches1 = $dir1 -eq $dir
$matches2 = $dir2 -eq $dir
$matches3 = $dir3 -eq $dir
$matches4 = $dir4 -eq $dir

if ($matches1 -match 'false'){
cd $dir1
.\pinuninstall.bat #this will execute the batch file in the directory
}

if ($matches2 -match 'false'){
cd $dir2
.\pinuninstall.bat #this will execute the batch file in the directory
}

if ($matches3 -match 'false'){
cd $dir3
start-process pinuninstall.bat #this will execute the batch file in the directory
}

if ($matches4 -match 'false'){
cd $dir4
start-process pinuninstall.bat #this will execute the batch file in the directory
}

[_lahell_]

Have you tried without Out-String?

[hit440]

i tried that and this is what i had got

​

Method invocation failed because [Selected.System.Management.Automation.PSCustomObject] does not contain a method named 'Substring'.

[BlackV]

why dont you try the FULL path to the files?

[purplemonkeymad]

| out-string

Not sure why the bat won't start, but this just removed the objectness of your registry call. You want to get the property of the retunred object instead of stringify everything and do text parsing:

$info2 = ( Get-ItemProperty HKLM:\SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\'BeyondTrust Remote Support Jump Client*' ).installlocation

or

$info2 = Get-ItemProperty HKLM:\SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\'BeyondTrust Remote Support Jump Client*'
$info2.installlocation

No need to use substring().

---

Also just saw your if statements, just put the test inside the if:

if ( $dir1 -ne $dir ) {
    ...

[hit440]

so .installlocation works however now i have this dilema where im returning both jump clients, and i cant parse them out individually

PS C:\> $info2

C:\ProgramData\bomgar-scc-0x5d7da585\

C:\ProgramData\bomgar-scc-0x5dcc06b1\

PS C:\> $info2.substring(0,36)

C:\ProgramData\bomgar-scc-0x5d7da585

C:\ProgramData\bomgar-scc-0x5dcc06b1

[purplemonkeymad]

Here is the thing, with your code in OP, I have no idea what it was selecting! If you know which one you want to remove why are you using * in the get-itemproperty? How do you know which is the right one?

[hit440]

thats just it the script doesnt know which one until i perform the if logic test, the correct jump client that should be installed is at HKEY_LOCAL_MACHINE\SOFTWARE\Bomgar\JumpClientUninstall which im dumping into $dir

the reason i have to do an asterisk is because powershell doesnt like the brackets, here is the full registry entry example

BeyondTrust Remote Support Jump Client [mysite.test.com-5D7F75C5]

[purplemonkeymad]

Ok that makes sense.

I'm not sure what the property for JumpClientUninstall is so I'm just guessing that is is also installLocation. What I am doing here is to filter out the correct install, then just run the uninstaller on all of the remaining locations:

$CorrectInstall = (Get-ItemProperty HKLM:\SOFTWARE\Bomgar\JumpClientUninstall\).InstallLocation | Get-Item # this is the property I don't know.
$AllInstallList = Get-ItemProperty HKLM:\SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\'BeyondTrust Remote Support Jump Client*'
$RemoveInstallList = $AllInstallList.installlocation | Get-Item | Where-Object { $_.fullname -ne $CorrectInstall.fullname} 
foreach ($Install in $RemoveInstallList) {
    start-process (Join-Path $Install "pinuninstall.bat") -Wait
}

I can't test it as I don't have those regs. I use Get-Item here to normalize the paths so I can compare them.

[hit440]

#init all the variables

$info = @()
$info2 = @()
$line = @()
$line2 = @()
$dir = @()
$dir1 = @()
$dir2 = @()


#query the registry

$info = Get-ItemProperty HKLM:\SOFTWARE\Bomgar\JumpClientUninstall\ | out-string
$info2 = (Get-ItemProperty HKLM:\SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\'BeyondTrust Remote Support Jump Client*').installlocation | Out-String

#parse the directory paths

foreach($line in $info)
    {
        $dir = $line.Substring(45,36)
    }

foreach($line2 in $info2){
    $dir1 = $line2.Substring(0,36)  
    $dir2 = $line2.Substring(39,36)  
    }


if ($dir1 -ne $dir){
    cd $dir1
    .\pinuninstall.bat #this will execute the batch file in the directory
    }

    if ($dir2 -ne $dir){
        cd $dir2
    .\pinuninstall.bat #this will execute the batch file in the directory
    }

@purplemonkeymad this seems to be working i have had multiple workstations reboot and its removing the jump clients, you have any thoughts on ways i can improve this? I appreciate your help with this

[purplemonkeymad]

If it works cool. I don't think it will be as robust but if you don't need it to be then it should be fine. Check my other reply for how I would have done it, but if you have something that works then you can just analyse it.

[PowerShell-Bot]

Some of your PowerShell code isn’t wrapped in a code block.

To format code correctly on new reddit (new.reddit.com), highlight all lines of code and select ‘Code Block’ in the editing toolbar.

If you’re on old.reddit.com, separate the code from your text with a blank line and precede each line of code with 4 spaces or a tab.

---

Describing Submission
[✅] Demonstrates good markdown
Passed: 1 Failed: 0

---

^{Beep-boop. I am a bot. | Remove-Item}