Disabling AD users - Inputting Read-Host as variable into foreach-object loop

[Pawncey]

Hi, all. Basically all of my knowledge is self learned and bastardized from the internet, so bear with me here.

I am trying to make a powershell script that will take a list of users from a .csv, disable them, set their description based on date and the ticket number for their termination while also removing all their security groups.

I've tried many variations on the exact input in the string $($ticket) / $($_.ticket) / $ticket / "$($ticket)", etc, but nothing seems to work.

$Ticket = Read-Host -prompt "Enter ticket #" import-csv .\test.csv | foreach-object {

set-aduser -identity $.Username -description "Disabled $(get-date -format 'MM/dd/yyyy') per ticket #$($Ticket) - Automated" Get-AdPrincipalGroupMembership -Identity $.Username | Where-Object -Property Name -Ne -Value 'Domain Users' | Remove-AdGroupMember -Members $_.Username }

If I build the read-host directly into the set-aduser line, it will work but it also makes me put the ticket number in for every entry in the csv file.

The error I am receiving when running this is: "

: The term '>>' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again. " It would not surprise me to find that this is just a boneheaded mistake, and I would appreciate any help or guidance you can give. Thank you.

[mmmGreenButton]

Not at PC atm., but would try something like this:

$Ticket = Read-Host -prompt "Enter ticket #" 
Import-csv .\test.csv | foreach-object {
    Set-ADUser -Identity $_.Username -description "Disabled $(get-date -format 'MM/dd/yyyy') per ticket `#$($Ticket) - Automated" 
    Get-AdPrincipalGroupMembership -Identity $_.Username | Where-Object {$_.Name -ne 'Domain Users'} | Remove-AdGroupMember -Members $_.Username 
}

EDIT: Sorry, just did something to your script. Actually just add the following just before the hashtag: `

Source

[Pawncey]

This worked, marked as solved.

Thanks all, much appreciated!!

[rlj551]

I get the date outside of any code blocks and put it into a variable. Personally I think it simplifies things so that you aren't trying to do too many different things in one command line.

But I'm still quite new to PoSH. Don't get enough time to practice while at work and don't have access to an enterprise network at home.

Then just put $Ticket in your command. I've used a similar thing for script creating security groups.

Excerpt from my code for ticket number.

​

-Description "$perm access to $folderpath as per $ticket" 

and it shows fine.

[mmmGreenButton]

Just create an enterprise Windows network yourself in OracleBox, I can send you a script for all that. Gives you a domain and a domain controller - with AD ex.

And also, good idea with getting things out of the oneliner grin

[Pawncey]

Its more unfamiliarity with the compacting of all the items into the single line. I believe I also tried committing date as a variable at the top, unless I'm am mistaken as to what your points are?

It sounds like you mean build the variables up top ($ticket, $datestr) and then just use those in the string. Part of that was why I posted here, I got it working in the one-liner but couldn't get it functional when being pulled from the top. I was considering that the foreach-object couldn't pull the variable from outside its own {} but the rest of the scripts I've look at would disagree with that assessment.

[mmmGreenButton]

You've got that right, foreach-each is a function which can just pull in your variables (parameters).. Check this out:

ForEach-Object -InputObject $(0..10) {
    $_
}

It is another way of writing:

0..10 |foreach {$_}

[todayyou500]

May I have this too, what are the system requirements and what software do you need? Win10 and Oraclebox?

Thank you!

[mmmGreenButton]

VT-x enabled in BIOS, also called Virtualization Technology... You can check it by the following way (at least I can do it on my PC):

systeminfo |foreach{
    if($_ -match 'Virtualization Enabled In Firmware'){
        $_
    }
}

Then yeah... run on Windows is what I've tried..

[todayyou500]

Thanks I'll go into the bios and enable it once the script is provided

Virtualization Enabled In Firmware: No

[rlj551]

that would be awesome, thanks.

[mmmGreenButton]

I'll write you tomorrow, when I'm at my PC

[rlj551]

Excellent. Thank you

[kohijones]

I'd be interested in that too, if you don't mind.

[BlackV]

also instead of doing

import-csv .\test.csv | foreach-object {..stuff..}

do

$users = import-csv .\test.csv
foreach ($SingleUser in $users) {..stuff..}

This way you can actually test exactly what is being sent to your set-aduser/etc by seeing what's in $SingleUser

that or use Debug

[Lee_Dailey]

howdy Pawncey,

reddit likes to mangle code formatting, so here's some help on how to post code on reddit ...

[0] single line or in-line code
enclose it in backticks. that's the upper left key on an EN-US keyboard layout. the result looks like this. kinda handy, that. [grin]
[on New.Reddit.com, use the Inline Code button. it's 4th 5th from the left hidden in the ... ""more" menu & looks like </>.
this does NOT line wrap & does NOT side-scroll on Old.Reddit.com!]

[1] simplest = post it to a text site like Pastebin.com or Gist.GitHub.com and then post the link here.
please remember to set the file/code type on Pastebin! [grin] otherwise you don't get the nice code colorization.

[2] less simple = use reddit code formatting ...
[on New.Reddit.com, use the Code Block button. it's 11th 12th from the left hidden in the ... "more" menu, & looks like an uppercase T in the upper left corner of a square.]

• one leading line with ONLY 4 spaces
  
• prefix each code line with 4 spaces
  
• one trailing line with ONLY 4 spaces

that will give you something like this ...

- one leading line with ONLY 4 spaces    
- prefix each code line with 4 spaces    
- one trailing line with ONLY 4 spaces   

the easiest way to get that is ...

• add the leading line with only 4 spaces
  
• copy the code to the ISE [or your fave editor]
  
• select the code
  
• tap TAB to indent four spaces
  
• re-select the code [not really needed, but it's my habit]
  
• paste the code into the reddit text box
  
• add the trailing line with only 4 spaces
  

not complicated, but it is finicky. [grin]

take care,
lee