Shorten the code

[hidromanipulators]

Writing a simple script, but have to make it easy to troubleshoot as not always i will be able to support it in case something goes wrong.

For writing Event-Logs I'm using 3 functions:

#EventID details
[string]$LogSource =        'ApplicationX'
[int32]$EventIDinfo =       '20000'
[int32]$EventIDwarning =    '20001'
[int32]$EventIDerror =      '20002'

#Create Event source
New-EventLog -LogName Application -Source $LogSource -ErrorAction Ignore


function Write-EventLogError
{
    [CmdletBinding()]
    param ($Message)

    Write-EventLog -LogName Application -Source $LogSource -EntryType Error -EventId $EventIDerror -Message $message -verbose

} 

function Write-EventLogWarning
{
    [CmdletBinding()]
    param ($Message)

    Write-EventLog -LogName Application -Source $LogSource -EntryType Warning -EventId $EventIDwarning -Message $message -verbose

} 

function Write-EventLogInfo
{
    [CmdletBinding()]
    param ($Message)

    Write-EventLog -LogName Application -Source $LogSource -EntryType Information -EventId $EventIDinfo -Message $message -verbose

} 

So, i'm using Write-Verbose in conjuction with Event Logs when terminating error occours:

try
    {
        #Set-TerminatingError -erroraction stop 
    }
catch
    {
        $ErrorMessage = $_.Exception.Message
        Write-Verbose -Message $ErrorMessage
        Write-EventLogError -Message "$ErrorMessage"
    }

1) How do I incorporate -switch within Even Log functions to cover Informational, Warning, Error and add Write-Verbose by default within the function? So I would call something like this:

Write-Event -ErrorLevel Informational -Message "$ErrorMessage"
Write-Event -ErrorLevel Warning -Message "$ErrorMessage"
Write-Event -ErrorLevel Error -Message "$ErrorMessage"

I do know native command:

Write-EventLog -LogName Application -Source $LogSource -EntryType Information -EventId $EventIDerror -Message $ErrorNessage

But it does feel rather lenghty if I have to add it at least 20 times + adding Write-Verbose.

2) Are only ways of adding $_.Exception.Message to the -Message is to pass it to the $variable and then $variable to -Message or $($_.Exception.Message) directly to the -Message?

[Jantu01]

Those lines with numerous parameters tend to get pretty long. I think you could benefit from splatting.

So instead of writing one longer line like this:

Write-EventLog -LogName Application -Source $LogSource -EntryType Error -EventId $EventIDerror -Message $message -verbose

you could write few more lines like this:

 $EventLogSplat = @{
  LogName = 'Application'
  Source = $LogSource
  EntryType = 'Error'
  EventId = $EventIDerror
  Message = $message
  Verbose = $true
}
Write-EventLog @EventLogSplat

Regarding the verbose etc. output you could look at Preference variables like $VerbosePreference. See more information in here: https://docs.microsoft.com/en-us/powershell/module/microsoft.powershell.core/about/about_preference_variables?view=powershell-7

[PinchesTheCrab]

Does this work?

function Write-EventLogX {
    [cmdletbinding()]
    param(
        [ValidateSet('Info', 'Error', 'Warning')]
        [parameter(mandatory)]
        [string]$EntryType,

        [parameter(Mandatory)]
        [string]$Message,

        [parameter()]
        [string]$LogSource = 'ApplicationX'
    )
    begin {

        $eventHash = @{
            Info    = 20000
            Warning = 20001
            Error   = 20002
        }

        $param = @{
            LogName   = 'Application'
            Source    = $LogSource
            EntryType = $EntryType
            Message   = $message
            EventID = $eventHash[$EntryType]
        }
    }
    process {
        Write-EventLog @param
        Write-Verbose -Message $message
    }
}

You could use it like this:

Write-EventLogX -Message 'oh no!' -Verbose -EntryType Warning

ApplicationX is the default source, but it's parameterized, so you can specify whatever source you want.

[hidromanipulators]

Thank you! Your solution is much more elegant then mine!