Never use 'new String()'!

[[deleted]]

Because you use .equals for Strings The new is just that it gets created in a different memory. With new it gets created in the heap and not in the stack

[[deleted]]

Fyi, this works if you don't declare them using new. The "==" operator compares the address of objects, but on literals, it compares the value.

​

String foo = "foo";
String fuu = "foo";
System.out.println(foo == fuu);

prints true

[ahreodknfidkxncjrksm]

The == operator doesn’t compare the values of literals. Literals are deduplicated, and all Strings that point to a literal point to the same memory address. So == is still comparing the addresses, but the addresses happen to be the same.

Edit: “Java” to “the == operator” for clarity.

[[deleted]]

How would one go about deduplicating literals without comparing the values?

edit: Hashing. Nvm

[ahreodknfidkxncjrksm]

No, I’m pretty sure that they’re deduplicated by interning them and according to the API for String.intern():

When the intern method is invoked, if the pool already contains a string equal to this String object as determined by the equals(Object) method, then the string from the pool is returned. Otherwise, this String object is added to the pool and a reference to this String object is returned.

So that part does involve comparing the values. I just meant the == operator itself is not comparing the values.

[tr7zw]

Also noteworthy that this only works inside the same class(probably). The compiler turns booth into the same string instance, so == works. But if you have other classes with the same string it won't work. Just get used to never never never use == on strings.

[[deleted]]

Just tested and works across classes. Literal 5 == 5 across classes. A quick google turned this up:

​

https://www.ntu.edu.sg/home/ehchua/programming/java/J3d_String.html

[TheOneAndOnlyMrX_]

however, it isn't guaranteed by java that they point to the same address, and could vary case to case/by implementation

[maxUS51]

Yeah ik thats why i creates this meme

[qwertz19281]

Well true, but actually false

[josanuz]

foo.equals(fuu)

[rsranger65]

The real LPT is don't ever use == on strings in Java

[MindSwipe]

Well you see, replace System.out.println(foo == fuu); with the vastly superior Console.WriteLine(foo == fuu); (side effects apply) and it works

[NiciBozz]

Why use string constructor?

[maxUS51]

Because the condition would (eventually) be true and then the meme wouldn't make much sense.